Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[iot-pmc] [CQ 19587] Eclipse VOLTTRON

http://dev.eclipse.org/ipzilla/show_bug.cgi?id=19587


Jens Reimann <jreimann@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jreimann@xxxxxxxxxx




--- Comment #6 from Jens Reimann <jreimann@xxxxxxxxxx>  2019-05-09 09:55:37 ---
Sorry for the delay on this one, maybe it was a bit too overwhelming. Still you
should have gotten a response sooner. You are always welcome to send out an
e-mail if you think something takes too long.

I did take a brief look at the archive, and found some stuff that doesn't seem
to belong here. Maybe you could clean up that archive a bit, so that we can
focus on the relevant stuff.

Like the comment says:

> Please only attach source that is required for the binary distribution.  Items
> that do not ship or do not build into binaries are not to be included in the
> source attachment.  Typical exclusions are tests, docs, and examples which are
> not included in the jar that is shipped.

I guess you are shipping the documentation in one way or the other. And I also
believe that for the initial contribution it makes sense to keep the tests.

However I found things like log files, test configs, or code that seems to come
form another source:

---
Based on the WhoIsIAm.py sample application from the BACpypes library.
---

Maybe you can re-iterate once more, and clear that out.

I also found a huge amound of 3rd party dependencies. I think it would help if
we could have a list of what will be required by the initial CQ from a
dependency point of view.


-- 
Configure CQmail: http://dev.eclipse.org/ipzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the CQ.


Back to the top