On 10/4/18 9:15 PM, Tom Jenkinson wrote:
>
>
> On 4 October 2018 at 17:20, Lukas Jungmann <lukas.jungmann@xxxxxxxxxx
> <mailto:lukas.jungmann@xxxxxxxxxx>> wrote:
[..]
> The run was on Oracle internal infrastructure. If you have tests,
> https://github.com/eclipse-ee4j/jakartaee-tck
> <https://github.com/eclipse-ee4j/jakartaee-tck> and/or
> https://github.com/eclipse-ee4j/metro-wsit/blob/master/wsit/hudson/cts-smoke.sh
> <https://github.com/eclipse-ee4j/metro-wsit/blob/master/wsit/hudson/cts-smoke.sh>
> could give you some hints about required set up. Note that there
> might be some JTA specific requirements/properties which I am not
> aware of.
>
>
> The readme in here https://github.com/eclipse-ee4j/jakartaee-tck says
> that we can't run the TCK yet: "we request you not to try building the
> CTS bundle from this repository
>
> Regarding the cts-smoke.sh it looks useful - thanks. But it's not clear
> where cts.zip comes from? I guess the script is run during the CI/CD
> pipeline of metro-wsit?
"If you have tests" was the important part of the sentence referring to
the point that you may have obtained tests bundle for the technology you
are working on from Oracle somehow in the past. If that is the case then
cts.zip being referred to in the script is the zip with tests. If not,
then you need to wait till CTS bundle from jakartaee-tck project becomes
available
So you are basically saying that we would need to use an existing EE8 CTS running locally to test this branch?
The problem with that is that if commiters have an existing copy of the CTS it would have been obtained under fairly strict licensing conditions from Oracle. I would not really be comfortable running the CTS we have obtained to test WildFly against EE4J Servlet and publishing the outcome without first verifying with our legal department that this will not breach our licensing agreement.
If this license agreement does prohibit this does this mean that the only way we can push to the EE4J_8 branch and follow the PMC rules is to either get an Oracle employee to run the TCK for us, or wait until jakartaee-tck becomes available?
Stuart
>
> I have to admit I didn't fully follow what you were saying earlier about
> the sequence of events that ran the TCK on json-p, are you saying that
> (for example)
> https://github.com/eclipse-ee4j/jsonp/commit/8a70aebb669607b67fff06adffd8729b4c302bf4
> was tested against a TCK somewhere before it was merged to the EE47_8
> branch
I don't think this change in particular was tested in affected projects
as this may, in some cases, require some changes on the TCK side due to
the artifact id change, ie looking at JTA[1] and comparing default
classpath (which I believe can be overridden somehow) to the new maven
coordinates[2], 'javax.servlet-api.jar' becomes
'jakarta.servlet-api.jar', so the current classpath 'as is' probably
needs to be updated first. How likely it is for the file rename to cause
test failures except of those checking its exact name match against some
pattern?
- it's not clear from the pull request
> (https://github.com/eclipse-ee4j/jsonp/pull/115) that the TCK was run on
> it prior to the PR being merged to that branch.
existing infra and what it does has been presented back in December[3],
don't think that it was recorded
To expand on the
> content, I am referring specifically to the requrirement "In order to
> merge a PR into the EE4J_8 branch project lead or PMC approval is
> required and the change must be tested against the TCK which is
> currently not available."
I believe this is still work in progress and evolving in time, ie from
September update[4]:
"The Eclipse Foundation has signed the Oracle Java EE TCK agreement,
which is going to allow us to ship Eclipse Glassfish certified as Java
EE 8 compatible. This has also required us to create a testing
infrastructure at the Eclipse Foundation, and allowed the EE4J projects
to begin testing against the Java EE 8 TCKs."
thanks,
--lukas
[1]:
https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/install/jta/bin/ts.jte#L73
[2]: https://github.com/eclipse-ee4j/ee4j/wiki/New-Maven-Coordinates
[3]: https://www.eclipse.org/lists/ee4j-build/msg00017.html
[4]:
https://blogs.eclipse.org/post/mike-milinkovich/jakarta-ee-status-%E2%80%93-september-2018-update
>
>
> thanks,
> --lukas
>
>
>
>
> On 4 October 2018 at 11:35, Mikaël Barbero
> <mikael.barbero@xxxxxxxxxxxxxxxxxxxxxx
> <mailto:mikael.barbero@xxxxxxxxxxxxxxxxxxxxxx>
> <mailto:mikael.barbero@xxxxxxxxxxxxxxxxxxxxxx
> <mailto:mikael.barbero@xxxxxxxxxxxxxxxxxxxxxx>>> wrote:
>
> Hi,
>
> I'm glad to inform you that all Jenkins instances for each
> and every
> EE4J projects are now configured and ready to use for
> building and
> publishing to Maven Central. GitHub credentials are also
> configured
> so that you can build pull requests and tag your
> repositories. See
> https://docs.google.com/spreadsheets/d/1O2NA6YddYQy34riTabQd_lkNwwFzKq1HevxCJYNXrv4/edit?usp=sharing
> <https://docs.google.com/spreadsheets/d/1O2NA6YddYQy34riTabQd_lkNwwFzKq1HevxCJYNXrv4/edit?usp=sharing>
>
> <https://docs.google.com/spreadsheets/d/1O2NA6YddYQy34riTabQd_lkNwwFzKq1HevxCJYNXrv4/edit?usp=sharing
> <https://docs.google.com/spreadsheets/d/1O2NA6YddYQy34riTabQd_lkNwwFzKq1HevxCJYNXrv4/edit?usp=sharing>> for
> the complete list of instances.
>
> We gather EE4j specific instructions on the following
> https://wiki.eclipse.org/EE4J_Build
> <https://wiki.eclipse.org/EE4J_Build>
> <https://wiki.eclipse.org/EE4J_Build
> <https://wiki.eclipse.org/EE4J_Build>>. Tomas also made a great
> guide
> available here
> https://github.com/eclipse-ee4j/jsonp/wiki/JSONP-release-job
> <https://github.com/eclipse-ee4j/jsonp/wiki/JSONP-release-job>
>
> <https://github.com/eclipse-ee4j/jsonp/wiki/JSONP-release-job
> <https://github.com/eclipse-ee4j/jsonp/wiki/JSONP-release-job>>
>
> If you face any issue with the instructions or other kind
> of issues,
> feel free to open ticket on the bugzilla
> https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Community&component=CI-Jenkins
> <https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Community&component=CI-Jenkins>
>
> <https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Community&component=CI-Jenkins
> <https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Community&component=CI-Jenkins>>
>
> Thanks.
> *
> Mikaël Barbero *
> *Team Lead - Release Engineering | Eclipse Foundation*
> 📱 (+33) 642 028 039 | 🐦 @mikbarbero
> Eclipse Foundation <http://www.eclipse.org/>: The Platform
> for Open
> Innovation and Collaboration
>
>
> _______________________________________________
> ee4j-build mailing list
> ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>
> <mailto:ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>>
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/ee4j-build
> <https://dev.eclipse.org/mailman/listinfo/ee4j-build>
> <https://dev.eclipse.org/mailman/listinfo/ee4j-build
> <https://dev.eclipse.org/mailman/listinfo/ee4j-build>>
>
>
>
>
> _______________________________________________
> ee4j-build mailing list
> ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/ee4j-build
> <https://dev.eclipse.org/mailman/listinfo/ee4j-build>
>
> _______________________________________________
> ee4j-build mailing list
> ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/ee4j-build
> <https://dev.eclipse.org/mailman/listinfo/ee4j-build>
>
>
>
>
> _______________________________________________
> ee4j-build mailing list
> ee4j-build@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/ee4j-build
>
_______________________________________________
ee4j-build mailing list
ee4j-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ee4j-build
