Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ee4j-build] Jenkins instances all configured


On 4 October 2018 at 17:20, Lukas Jungmann <lukas.jungmann@xxxxxxxxxx> wrote:
On 10/4/18 3:37 PM, Tom Jenkinson wrote:
Great to hear!

I just want to highlight a point I made elsewhere but it relates to JSON-P in your email:

There are commits here:
https://github.com/eclipse-ee4j/jsonp/commits/EE4J_8 <https://github.com/eclipse-ee4j/jsonp/commits/EE4J_8>

But were these commits all run against the TCK/CTS?

@glassfishrobot user runs all tests during integration into glassfish (see ie https://github.com/javaee/glassfish/pull/22586 or https://github.com/javaee/glassfish/pull/22590) within 'javaee' org repos. Since EE4J_8 branch in repos within 'eclipse-ee4j' org is supposed to match its 'javaee' origin, all changes in 'javaee' repos need to be ported to EE4J space. So yes, code changes were run against TCK/CTS (and glassfish specific tests suites - quicklook and devtests). I'm not sure if the public infra has been already set up to run same amount of tests against code in eclipse-ee4j/EE4J_8


 The reason I ask is
the following article:
https://www.eclipse.org/ee4j/news/?date=2018-02-16
Perhaps that is no longer a requirement? Or maybe it is only required if there are changes in the Java but the guidance on the article was not explicit?

If the TCK/CTS was run, it would be great to know how so that I can try to replicate the same setup for changes on the JTA project.

 The run was on Oracle internal infrastructure. If you have tests, https://github.com/eclipse-ee4j/jakartaee-tck and/or https://github.com/eclipse-ee4j/metro-wsit/blob/master/wsit/hudson/cts-smoke.sh could give you some hints about required set up. Note that there might be some JTA specific requirements/properties which I am not aware of.

The readme in here https://github.com/eclipse-ee4j/jakartaee-tck says that we can't run the TCK yet: "we request you not to try building the CTS bundle from this repository

Regarding the cts-smoke.sh it looks useful - thanks. But it's not clear where cts.zip comes from?  I guess the script is run during the CI/CD pipeline of metro-wsit?

I have to admit I didn't fully follow what you were saying earlier about the sequence of events that ran the TCK on json-p, are you saying that (for example) https://github.com/eclipse-ee4j/jsonp/commit/8a70aebb669607b67fff06adffd8729b4c302bf4 was tested against a TCK somewhere before it was merged to the EE47_8 branch - it's not clear from the pull request (https://github.com/eclipse-ee4j/jsonp/pull/115) that the TCK was run on it prior to the PR being merged to that branch. To expand on the content, I am referring specifically to the requrirement "In order to merge a PR into the EE4J_8 branch project lead or PMC approval is required and the change must be tested against the TCK which is currently not available."


thanks,
--lukas




On 4 October 2018 at 11:35, Mikaël Barbero <mikael.barbero@eclipse-foundation.org <mailto:mikael.barbero@eclipse-foundation.org>> wrote:

    Hi,

    I'm glad to inform you that all Jenkins instances for each and every
    EE4J projects are now configured and ready to use for building and
    publishing to Maven Central. GitHub credentials are also configured
    so that you can build pull requests and tag your repositories. See
    https://docs.google.com/spreadsheets/d/1O2NA6YddYQy34riTabQd_lkNwwFzKq1HevxCJYNXrv4/edit?usp=sharing
    <https://docs.google.com/spreadsheets/d/1O2NA6YddYQy34riTabQd_lkNwwFzKq1HevxCJYNXrv4/edit?usp=sharing> for
    the complete list of instances.

    We gather EE4j specific instructions on the following
    https://wiki.eclipse.org/EE4J_Build
     <https://wiki.eclipse.org/EE4J_Build>. Tomas also made a great guide
    available here
    https://github.com/eclipse-ee4j/jsonp/wiki/JSONP-release-job
    <https://github.com/eclipse-ee4j/jsonp/wiki/JSONP-release-job>

    If you face any issue with the instructions or other kind of issues,
    feel free to open ticket on the bugzilla
    https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Community&component=CI-Jenkins
     <https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Community&component=CI-Jenkins>

    Thanks.
    *
    Mikaël Barbero *
    *Team Lead - Release Engineering | Eclipse Foundation*
    📱 (+33) 642 028 039 | 🐦 @mikbarbero
     Eclipse Foundation <http://www.eclipse.org/>: The Platform for Open
    Innovation and Collaboration


    _______________________________________________
    ee4j-build mailing list
     ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>
    To change your delivery options, retrieve your password, or
    unsubscribe from this list, visit
    https://dev.eclipse.org/mailman/listinfo/ee4j-build
     <https://dev.eclipse.org/mailman/listinfo/ee4j-build>




_______________________________________________
ee4j-build mailing list
ee4j-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ee4j-build

_______________________________________________
ee4j-build mailing list
ee4j-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ee4j-build

Back to the top