Re: [dsdp-mtj-dev] Initial MTJ api code commits

[Craig Setera <craigjunk@xxxxxxxxxx>]

This all seems reasonable.  Thanks for the insights.

Diego Madruga Sandin wrote:

Hi Craig,

I saw the SourceMapper as an internal API, so I exported as x-friends, making it public to org.eclipse.mtj.core and org.eclipse.jdt.core . Although being made internal, it still can be accessed by other plug-ins.

I did the same with other packages that was also an internal API. I only exported them to the required plug-ins. For example, all toolkis are now internal, but they are public to the core and the ui.

Since that a lot of implementation classes were made private, 2 migration classes were created to upgrade the previous workspace to be compatible with the new one.

• org.eclipse.mtj.internal.core.util.migration.DeviceRegistryMigration
• org.eclipse.mtj.internal.core.util.migration.SymbolDefinitionsMigration

This classes updates the devices and symbol definition files respectively.

One other change that was made was to bundle up the two plug-ins that were used as examples(motorola and me4se) together in a new plug-in called org.eclipse.mtj.examples.toolkits

I also removed the use of some internal classes from jdt, since now (3.4.0) there is a way to access them from public factories and updated some implementations that was using deprecated methods.

All the modifications kept in mind that we need to be compatible with eclipse 3.4 and 3.5. but we lost the 3.3 compatibility.

Well, that's all for now :)

please, send comments, questions etc,
Diego

On Sat, Feb 7, 2009 at 3:25 PM, Craig Setera <craigjunk@xxxxxxxxxx> wrote:

Gustavo,

Nice work on this refactoring.  I scanned the incoming changes and things made sense.  The only thing I wasn't sure about was that in the core hooks that SourceMapper was made internal.  While I understand that we are really the only ones using this, the fact that it is registered from another plugin makes me wonder if this is still "public" API?  Not sure to be honest.

What are your thoughts on the extension points at this point?  Any thoughts about my comments on the wiki?

Thanks,
Craig

Paula Gustavo-WGP010 wrote:

Hi MTJ,

We finished some of the initial MTJ api re-factoring based on the proposal that is on the wiki. Today we plan to commit those changes. The idea of this commit is just to make it easy for everyone to review and give feedback, since you will be able to see the documentation and also the code.

MTJ 1.0M5 was just released and has a tag with all the code before any API re-factoring change. So, in the worst case, it is possible to rollback everything if there is a community decision to do that. The focus of this commits are:

-       Follow as much as possible all guidelines from eclipse API central http://wiki.eclipse.org/API_Central;
-       Keep as api only what is suppose to be an api. The rest was moved to internal packages;
-       Re-factory some of the code.

Next Tuesday nightly build will have those initial changes. There are two ways to review the code / documentation: checkout the trunk or download next Tuesday nightly build. If you want to compare with what was previously available, just checkout tag/1.0M5 in a separated workspace or download 1.0M5.

Changes on this initial proposal can be discussed on the list or via bugzilla. When opening bugs, please tag them with [api] on the subject to make it easy to identify them.

Comments and contributions are very welcome. They will enable MTJ community to have a good initial API on MTJ 1.0 release.

J

gep

_______________________________________________
dsdp-mtj-dev mailing list
dsdp-mtj-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-mtj-dev
  

_______________________________________________
dsdp-mtj-dev mailing list
dsdp-mtj-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-mtj-dev

--
Diego Madruga Sandin
Linux User #416542

_______________________________________________
dsdp-mtj-dev mailing list
dsdp-mtj-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-mtj-dev