Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [che-dev] Java Test Runner Plugin - Progress Update
Hi,
Very nice :).
One question can you show running process output, it will be more useful?

But anyway great job!!!

Vitaly Parfonov -- codenvy

On Tue, Jun 14, 2016 at 4:48 PM, Mirage Abeysekara <mirage.12@xxxxxxxxxxxxx> wrote:

Thanks for the suggestions, I will update the plugin :)

Mirage Abeysekara
Undergraduate
Computer Science and Engineering
University of Moratuwa

On 13 June 2016 at 23:33, Tyler Jewell <tyler@xxxxxxxxxxx> wrote:
Wow - incredible progress.

1. Please connect with Stevan LeMeur about having proper icons incorporated that match design + IP standards.

2. In the right click menu - you say "Testing -> Run Class" or "Testing -> Run All".
a.  I think "Unit Test" or "Test" may be better.
b.  Not all of the files you selected were classes.  Sometimes you could select a pom.xml.  That is not a "class" so the context is not accurate.  So maybe "Unit Test -> Class", "Unit Test -> Project".  But if you do not select a class, then it should say something different. 
c.  Should there be a sub-menu off of the class level that lists each individual test available in a single file?  You had two tests in a single class, for example.  Can a user run just a single test?

3. How does a user close the Test Results panel?

4. We'll need to help you with some of the notification grammar.  "1 tests are failed" --> "1 test failed".  "2 tests are failed." --> "2 tests failed."



Tyler Jewell | CEO | tyler@​codenvy.​com | 9​78​.8​84​.53​55


On Mon, Jun 13, 2016 at 10:14 AM, Sun Tan <sun.tan@xxxxxxxxx> wrote:

This is minor... I'm not sure if it is the case but icons should be green or red depending on test success/ failure


Le lun. 13 juin 2016 19:11, Sun Tan <sun.tan@xxxxxxxxx> a écrit :

Hi Mirage, this is very good ;)


Le lun. 13 juin 2016 18:29, Mirage Abeysekara <mirage.12@xxxxxxxxxxxxx> a écrit :
Hi all,

Here is the video demonstration of the java test runner plugin with new user interface as suggested. :)

The following UI improvements are added to the plugin.
  • Right click option to run the test cases for Java classes.
  • Right click option to run all testable Java classes.
  • Console panel test results with improved readability and navigation.
  • Fixed the notification alerts about the test runner execution.
  • Test runner menu items are added to the Run menu group.
  • Added new icons.
Any feedback or suggestions are highly appreciated.

Thanks.

Mirage Abeysekara
Undergraduate
Computer Science and Engineering
University of Moratuwa

On 8 June 2016 at 23:08, Tyler Jewell <tyler@xxxxxxxxxxx> wrote:
Great!

Please be prepared for the PR process to take some time.  You will have >30 engineers reviewing your code & suggestions.  They will be very picky about coding standards :)

One other thing - I do think we can have some menu options, but put those options in the Run... menu.  Please suggest what those menu items might be and we can review.
1. We need to have a key binding for each menu item, so pick one that is not commonly used.
2. Fewer words to describe the menu item is very important.  So Run --> Unit Test, as an example.  I am not saying that this is the language to use, but it's a sample.

Tyler Jewell | CEO | tyler@​codenvy.​com | 9​78​.8​84​.53​55


On Wed, Jun 8, 2016 at 10:31 AM, Mirage Abeysekara <mirage.12@xxxxxxxxxxxxx> wrote:
Yes, it currently support for maven projects and JUnit4x. It can extendable to add multiple testing frameworks.

Thanks for the suggestions, I will improve the plugin and send a PR :) 



Mirage Abeysekara
Undergraduate
Computer Science and Engineering
University of Moratuwa

On 8 June 2016 at 22:20, Tyler Jewell <tyler@xxxxxxxxxxx> wrote:
wow wow wow wow!!!

This is fairly impressive for a summer project. 

This is going to be immensely useful to a variety of people who are using Che.

I have a number of points of feedback that will need to be considered for it to get merged.

1) is this for blank project types, java, maven, ??? 

2) Can this be extended for different kinds of project types?

3) UX - I am not a fan of having more menus.  We need to reduce menus in the product until we can give users a dynamic plugin deployment / removal features.  So I propose:
3a) You should have a right click option on the Java class to run tests.  You could have it then have a sub-menu thta lets' you run all tests, or select a specific one.
3b) The output for the various tests that are being run - I would image that appearing in the consoles panel - not as a popup.  I am working to get rid of popups in the product - as it makes for an inconsistent user experience.  It's easier for people to understand what is happening if we find a way to channel everything into a nice view on the consoles panel.

4) The notifications usage should be tweaked.  Having a failed unit test is not a cause for a red alert notification.  The test runner itself was successful - so if you want to alert people that it's done, it would always be green.  Yellow or red would mean that there was some issue with the execution of the runner itself - as a type of error condition.

When do we see the PR? :)

Tyler Jewell | CEO | tyler@​codenvy.​com | 9​78​.8​84​.53​55


On Wed, Jun 8, 2016 at 9:42 AM, Sun Tan <sun.tan@xxxxxxxxx> wrote:
Hi,
Very nice :)
Would be nice to show your panel in a "View" (next to console tab ?)

Le mer. 8 juin 2016 à 18:04, Mirage Abeysekara <mirage.12@xxxxxxxxxxxxx> a écrit :
Hello everyone,

I'm working on adding the Java Test Runner plugin for Eclipse Che as my Google Summer of Code project. Currently the following requirements[1] are added to the plugin.
  • GUI for showing test runner state
  • View the details of a failing test
  • Navigation to the failing class
  • Extendable framework
A brief video demonstration of the current implementation can view from this URL

Source code: https://github.com/Mirage20/che/tree/che-java-test-runner/plugins/plugin-java-test-runner

Any feedback or suggestions are highly appreciated.

[1] Please refer e-mail subject "Java Test Runner Plugin - Requirements" for more information about the plugin requirements.

Thanks.

Mirage Abeysekara
Undergraduate
Computer Science and Engineering
University of Moratuwa
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev
--


-- 

Sun Seng David TAN
Senior Java Developer
Eclipse Che commiter


Mobile : +33 21 02 41 73

Email : sun.tan@xxxxxxxxx

Site Web : www.serli.com


Suivez-nous sur Twitter : @SerliFr @sunsengdavidtan et Facebook : SerliFr  


_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev



_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev



_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev



_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev


_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev
--


-- 

Sun Seng David TAN
Senior Java Developer
Eclipse Che commiter


Mobile : +33 21 02 41 73

Email : sun.tan@xxxxxxxxx

Site Web : www.serli.com


Suivez-nous sur Twitter : @SerliFr @sunsengdavidtan et Facebook : SerliFr  

--


-- 

Sun Seng David TAN
Senior Java Developer
Eclipse Che commiter


Mobile : +33 21 02 41 73

Email : sun.tan@xxxxxxxxx

Site Web : www.serli.com


Suivez-nous sur Twitter : @SerliFr @sunsengdavidtan et Facebook : SerliFr  


_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev



_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev



_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev


Back to the top