Re: [che-dev] ProjectService GET vs PUT properties

[Maxim Shaposhnik <mshaposhnik@xxxxxxxxxxx>]

Factories is the only part of problem (we can write query to update them all in DB).
The main problem is that project configuration files on the filesystem also use same properte name, and this case is much difficutl to fix (we need to update all existing user projects).

So seems much easier to make all classes use the propety named "mixinTypes". It looks like only ProjectDescriptor and Project module classes should be updated (they're using "mixins" instead of "mixinTypes").

On Thu, Sep 10, 2015 at 11:39 AM, Sharafy, Tareq <tareq.sharafy@xxxxxxx> wrote:

Hi Maxim,

Correct, Factory definitions contain NewProject JSONs which were affected here.

Do we have an estimation for how many existing factories define mix-in types? If they are written in java, then the code would simply break and a tiny code fix will do the job. In my humble opinion it is worth it given the API confusion I described in this thread.

thank you
Tareq Sharafy

 

From: che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx] On Behalf Of Maxim Shaposhnik
Sent: Thursday 10 September 2015 11:03

To: che developer discussions <che-dev@xxxxxxxxxxx>
Subject: Re: [che-dev] ProjectService GET vs PUT properties

 

But we shuld deal with things like

"mixinTypes": [
      "contribution"
    ]

in existing factries.

 

On Thu, Sep 10, 2015 at 10:52 AM, Maxim Shaposhnik <mshaposhnik@xxxxxxxxxxx> wrote:

Pls also take in account this small change https://github.com/codenvy/plugins/pull/16/files

 

 

On Wed, Sep 9, 2015 at 3:33 PM, Sharafy, Tareq <tareq.sharafy@xxxxxxx> wrote:

Hi,

I made a pull request with the suggested change.
https://github.com/codenvy/che-core/pull/243
please review

thank you
Tareq Sharafy

 

From: che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx] On Behalf Of Vitalii Parfonov
Sent: Wednesday 09 September 2015 13:15
To: che developer discussions <che-dev@xxxxxxxxxxx>
Subject: Re: [che-dev] ProjectService GET vs PUT properties

 

Hi, yes you are right. This is mistake. We will fix it or you can prepare PR :)

Vitaly Parfonov -- codenvy

 

On Tue, Sep 8, 2015 at 3:41 PM, Sharafy, Tareq <tareq.sharafy@xxxxxxx> wrote:

Hi,

I am noticing an inconsistency between the request/response JSON fields of the project service APIs.

The list of mix-in types is returned by the metadata service GET /project/{ws}/{path} in a property named "mixins". However, the list of mix-in types that is received by the update service PUT /project/{ws}/{path} is expected to be in a property named "mixinTypes". The response of the project update service is again the same as the metadata service. This leads to some confusion and ad-hoc workarounds in some client code we are trying to write.

Shouldn't the JSONs that are send back and forth be as similar as possible?

thank you
Tareq Sharafy
Cloud Development Experience | SAP Labs Israel | 15 Hatidhar st, Raanana 43665, Israel
T +972-(0)7-4732-1647 | F +972-(0)9-777-5618

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev

 

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev

 

 

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev