Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [che-dev] ProjectService GET vs PUT properties

Hi Maxim,

The link you sent isn't available – seems it's outdated.

 

thank you
Tareq Sharafy

 

From: che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx] On Behalf Of Maxim Shaposhnik
Sent: Thursday 10 September 2015 10:52
To: che developer discussions <che-dev@xxxxxxxxxxx>
Subject: Re: [che-dev] ProjectService GET vs PUT properties

 

Pls also take in account this small change https://github.com/codenvy/plugins/pull/16/files

 

On Wed, Sep 9, 2015 at 3:33 PM, Sharafy, Tareq <tareq.sharafy@xxxxxxx> wrote:

Hi,

I made a pull request with the suggested change.
https://github.com/codenvy/che-core/pull/243
please review

thank you
Tareq Sharafy

 

From: che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx] On Behalf Of Vitalii Parfonov
Sent: Wednesday 09 September 2015 13:15
To: che developer discussions <che-dev@xxxxxxxxxxx>
Subject: Re: [che-dev] ProjectService GET vs PUT properties

 

Hi, yes you are right. This is mistake. We will fix it or you can prepare PR :)


Vitaly Parfonov -- codenvy

 

On Tue, Sep 8, 2015 at 3:41 PM, Sharafy, Tareq <tareq.sharafy@xxxxxxx> wrote:

Hi,

I am noticing an inconsistency between the request/response JSON fields of the project service APIs.

The list of mix-in types is returned by the metadata service GET /project/{ws}/{path} in a property named "mixins". However, the list of mix-in types that is received by the update service PUT /project/{ws}/{path} is expected to be in a property named "mixinTypes". The response of the project update service is again the same as the metadata service. This leads to some confusion and ad-hoc workarounds in some client code we are trying to write.

Shouldn't the JSONs that are send back and forth be as similar as possible?

thank you
Tareq Sharafy
Cloud Development Experience | SAP Labs Israel | 15 Hatidhar st, Raanana 43665, Israel
T +972-(0)7-4732-1647 | F +972-(0)9-777-5618


_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev

 


_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev

 


Back to the top