Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cargotracker-dev] Proposed change to xhtml syntax due to MyFaces compatibility issue
I just closed and re-opened the PR, which triggers a re-check - which still failed. When did you update your ECA? It does take some time to propagate.

Anyway, you should be able to check/recheck the ECA status yourself. There is a possibility you might need to withdraw and resubmit the PR, I am not sure

From: Chanun Ong <chanun@xxxxxxxxxxxx>
Sent: Friday, May 27, 2022 6:20 PM
To: cargotracker developer discussions <cargotracker-dev@xxxxxxxxxxx>; reza_rahman@xxxxxxxxx <reza_rahman@xxxxxxxxx>
Subject: Re: [cargotracker-dev] Proposed change to xhtml syntax due to MyFaces compatibility issue
 
Hi Reza,

I just updated my ECA so that should be good to go; let me know if it's still not going through

Thanks, 

Chanun Ong
University of California, Berkeley
Electrical Engineering & Computer Science, B.S. 
Class of 2022


On Fri, May 27, 2022 at 3:08 PM reza_rahman@xxxxxxxxx <reza_rahman@xxxxxxxxx> wrote:
The change looks fine. Can you please sign the ECA: https://www.eclipse.org/legal/ECA.php. Right now the IP check is failing and I can’t merge without IP clearance.

From: cargotracker-dev <cargotracker-dev-bounces@xxxxxxxxxxx> on behalf of Chanun Ong <chanun@xxxxxxxxxxxx>
Sent: Friday, May 27, 2022 6:02 PM
To: cargotracker developer discussions <cargotracker-dev@xxxxxxxxxxx>
Subject: [cargotracker-dev] Proposed change to xhtml syntax due to MyFaces compatibility issue
 
Hi Cargo Tracker developers,

I've proposed a new PR that includes a minor change to the xhtml syntax for the arrival destination and date dialogs (src/main/webapp/admin/dialogs) where I swap the <h:body> tag to <body>.

The reason behind this change is that using the <h:body> tag with the <f:metadata> tag causes an exception: (<f:metadata> Parent UIComponent a should be instance of UIViewRoot) when using Open Liberty with MyFaces, seen here: https://github.com/eclipse-ee4j/mojarra/issues/5105 and https://github.com/adminfaces/admin-template/issues/61. As documented in the above issues, Mojarra should also throw an exception but currently does not. This change doesn't affect the display or behavior when the app is run on Payara.

Let me know what you think!

Best,

Chanun Ong
University of California, Berkeley
Electrical Engineering & Computer Science, B.S. 
Class of 2022
_______________________________________________
cargotracker-dev mailing list
cargotracker-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/cargotracker-dev

Back to the top