[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
RE: [atf-dev] Proposed source code the Xulrunner extension
|
Javier wrote:
>So we would need to do the following changes:
>1) Have org.eclipse.atf.mozilla.swt.browser plugin load & execute on
startup, using the "org.eclipse.ui.startup" extension point. It would
execute MozillaHelper.definedContributedXulRunner ().
>2) Remove the line "MozillaHelper.definedContributedXulRunner(null)"
from MozBrowserEditor.java.
I have committed that in the branch.
Now a question: what if the System.property
org.eclipse.swt.browser.XULRunnerPath is already defined?
Like with a command line system.property?
Should we honor that instead of the an embedded or registered xulrunner?
I suggest the following:
1/ if a system property already exist, always honour it, if it satisfies
the version range.
2/ then we try to get a contributed embedded xulrunner that satisfies
the versions range
Other cases like global registered xulrunner are already handled by SWT.
What do you think?
--
Cheers
Philippe
philippe ombredanne | 1 650 799 0949 | pombredanne at nexb.com
nexB - Open by Design (tm) - http://www.nexb.com
-----Original Message-----
From: atf-dev-bounces@xxxxxxxxxxx [mailto:atf-dev-bounces@xxxxxxxxxxx]
On Behalf Of Javier Pedemonte
Sent: Friday, September 07, 2007 2:21 PM
To: AJAX Toolkit Framework discussion
Subject: Re: [atf-dev] Proposed source code the Xulrunner extension
The changes in org.eclipse.atf.mozilla.swt.browser don't address
https://bugs.eclipse.org/bugs/show_bug.cgi?id=201774.
Until the XULRunner extension issue is handled by the platform, we'll
need for the org.eclipse.atf.mozilla.swt.browser plugin to load at
startup in order to set the XULRUNNER_PATH property.
Currently (even with these latest changes), the XULRUNNER_PATH property
is only set when opening the ATF MozBrowserEditor. However, if the SWT
Browser is instantiated before MozBrowserEditor, then XULRUNNER_PATH is
never properly set, and ATF will not function as expected.
So we would need to do the following changes:
1) Have org.eclipse.atf.mozilla.swt.browser plugin load & execute on
startup, using the "org.eclipse.ui.startup" extension point. It would
execute MozillaHelper.definedContributedXulRunner ().
2) Remove the line "MozillaHelper.definedContributedXulRunner(null)"
from MozBrowserEditor.java.
Javier Pedemonte
ATF Developer
