Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-releng] Support for JUnit 4 is now in the Eclipse test framework ... and what to do about it


This matches my experience (with latest prereqs), and I think is the expected behavior "in the IDE" if you don't migrate to junit 4 (and don't remove JUnit 4 from your target).
In your test bundles, you currently specify
(and run with JUnit 3)
but somewhere else, in the JDT/PDE test framework as it has started to run first, it has already loaded classes from JUnit 4 ... so runs into some class clashes of one sort or another.

I think we "magically" (or, luckily) still work in batch builds, just due to the exact way we do it, and the order things are loaded, and in theory we might break later.

So, in the mean time (before, or if you don't want to migrate) you can remove JUnit version 4 from your target (as you've seen).

I do think (after this milestone) we should all migrate to JUnit 4, to be consistent, as well as I know some people that actually _want_ to use JUnit 4! :)

Oh, and when I say "migrate", the first course of action should be to just try and be compatible, to work with either JUnit 3 or 4. Its pretty easy to see the changes you need, by removing (unchecking) JUnit 3 in your target, and leaving JUnit version 4 enabled.

I have noticed you in Dali do use org.junit4 in one of your test utility bundles, and that might work for a while, but depends on use of "require bundle" vs. "import package". They will remove it after 3.6 ships, so just as well migrate off it this release.

We had an interesting case with JSDT the other day with latest prereqs, since it has a "stand-alone build" that does not require JDT, so its tests broke since JUnit 3 is no longer included in the Platform's test framework! (only in JDT). [Thanks to Nitin for the quick fixes to widen ranges, and make a compatible set of test bundles].  

Thanks for the experience report

From: karen moore <karen.moore@xxxxxxxxxx>
To: Webtools releng discussion list <wtp-releng@xxxxxxxxxxx>
Date: 12/09/2009 03:23 PM
Subject: Re: [wtp-releng] Support for JUnit 4 is now in the Eclipse test        framework ... and what to do about it
Sent by: wtp-releng-bounces@xxxxxxxxxxx

I am unsure why this would happen, but I wanted to report it in case anyone else hits this problem or has a clue as to why it's happening.  I updated my target platform to the latest M4 build, including the updated eclipse platform build (my dev environment is Eclipse 3.5.1).  I tried to run my tests (still using junit3) and received a CCE:
java.lang.ClassCastException: junit.framework.TestSuite cannot be cast to junit.framework.Test
   at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestLoader.getTest(
   at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestLoader.loadTests(
   at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(

An obviously weird CCE that doesn't make sense.  I started poking around my target platform and realized the the eclipse platform zip includes two JUnit4 plugin folders:

I deleted the first one (since it didn't match the naming from the last platform build) from the plugins folder and then reran my tests and they worked fine.  Any ideas?


On 11/30/2009 10:47 PM, David M Williams wrote:

Good new and bad news: JUnit 4 is now supported by the Eclipse test framework,
but JUnit 3 no longer is. Well, mostly no longer is. So, we'll have to change

some things.

The referenced write up is pretty good at describing what we'd have to do to migrate to JUnit 4.
Which I'd summarize as:

A. Widen or raise org.junit prereq bundle version ranges.
We should use the recommended, open-ended "3.8" until you know you are using something that is 4.x specific.

B. Subclasses of TestSuite that override 'tests()' have some work to do. >From what I can see,
from what's in my workspace, that involves only the server team, and these bundles below.
I _think_ the fix is easy ... but ... someone would have to study it and do it and _maybe_
coordinate when to release the code (can probably be changed in a compatible way, so runs
with either, but I'm not certain).










C. Custom subclasses of junit.framework.TestResult.
The JUnit class TestResult changed several of its protected fields from Vector to List.

The following list are those bundles I could easily see that subclassed TestResult. Not all
of them use the Vector fields ... but many do. You'll have to check your own. Appears to
involve many teams. I'm less sure this can be done in a compatible way ... may need to
time the release ... but, maybe. Please investigate. Maybe you can do without the subclass

or field access?


D. I'm sure there's stuff not in my workspace, so every component or subproject will need to investigate and test in their workspace.
Until we move up to new test framework, you can get a copy of JUnit 4 directly from Orbit.

So what to do about it? We will discuss and decide at our next Status meeting on Thursday.

Roughly, the options are:

1. Full speed ahead, be assimilated, migrate as soon as possible.
2.. Go slow and custom tweak our test environment so it'd have only JUnit 3 for those tests that do not want to change, and JUnit 4 for those that do want to change.
3. Some bright person figures out a way we can have our own Test Framework that works just like we want it to. Any volunteers? :)

So, give it some study. Give it some thought.  We'll discuss and decide on Thursday.

If or when you find things you have to change, I recommend you open a bug with "React to JUnit 4 Test Framework" in the summary and CC me, so I'll know when we are done and safe to update to new pre-reqs, assuming we do.

----- Forwarded by David M Williams/Raleigh/IBM on 11/27/2009 10:48 PM -----
From: John Arthorne <John_Arthorne@xxxxxxxxxx>
To:, eclipse-dev@xxxxxxxxxxx
Date: 11/26/2009 11:24 AM
Subject: [] Support for JUnit 4 in the Eclipse test        framework
Sent by:

If you are using the Eclipse platform's test framework for running your automated JUnit tests, please read on for important details about changes coming in the Helios M4 milestone.

The Eclipse test framework has had a long-standing request to add support for running with JUnit version 4. See bug 153429 with 40 votes and 75 people on the CC list to get an idea of the interest in this change. After a great deal of work by the JDT, Platform Releng, and Equinox teams, this support is coming in the Helios release. Unfortunately it was not possible to implement this enhancement in a completely transparent way for clients of the Eclipse test framework. For most clients migration to JUnit4 will be as simple as changing your test bundles' dependency on org.junit to include JUnit 4.x in its version range. We are recommending setting your dependency on org.junit to a range of "3.8.1", which encompasses all versions of JUnit shipped by the platform since the Callisto (June 2006) release.

For complete details on the steps required to transition to using JUnit4 or to continue using JUnit3, please see:

Comments and further feedback are welcome in the bug report:

_______________________________________________ mailing list

IMPORTANT: Membership in this list is generated by processes internal to the Eclipse Foundation.  To be permanently removed from this list, you must contact
emo@xxxxxxxxxxx to request removal.

wtp-releng mailing list
wtp-releng mailing list

Back to the top