|[wtp-dev] JSON Editor contribution is approved|
Hi All! We've finally got the JSON Editor contribution approved, see: BugZilla for the contribution:- https://bugs.eclipse.org/bugs/show_bug.cgi?id=471820 - [contribution] Eclipse WTP JSON Editor
CQs for the contribution and supplementary libraries & JSON schemas: - http://dev.eclipse.org/ipzilla/show_bug.cgi?id=9924 - JSON Editor- http://dev.eclipse.org/ipzilla/show_bug.cgi?id=10061 - minimal-json Version: 0.9.4 - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=10236 - Use/redistribute JSON Schemas originally published at schemastore.org
We still have few minor issues to fix, but it wouldn't take too long to get the final commit ready:
- we have to fix the icons (we'll put en empty ones in order not to have licensing issues and open the new issue in order to contribute the icons); - we have to remove some extra file (an old license file that is not valid anymore);
- we have to move into org.eclipse.wst.* namespace - we have to setup a maven project configs for plug-ins and new featuresDuring few discussions that took place during last few weeks we're all agreed to put this contribution into WTP SSE repository (correct me if I'm wrong), so given the fact of moving the repository into Gerrit and merging the webtools.sourceediting.tests repository into it, I have the following questions:
- Should we wait for the finish of Gerrit adoption process or we can attach the final patch for the issue (bug #471820) before we proceed with actual code pushing? And how the adoption goes for webtools.sourceediting? (IMHO, it's better to propose a change in Gerrit instead of just a text patch attachment for the contribution...) - Should we wait for the webtools.sourceediting.tests to be finally merged into webtools.sourceediting repository? (As far as I understood, not only the tests are to be merged, but the overall maven project is to be fixed during the merge, so we have to use the latest projects configuration for the contribution.) - Are we able to put JSON Editor plug-ins into webtools.sourceediting/bundles (without creating any extra folders)? - Is it OK to use org.eclipse.wst.json.* namespace for JSON Editor plug-ins and features?
We still targeting the contribution for Neon Release. Thanks in advance, Victor Rubezhny, JSDT --CONFIDENTIALITY NOTICE: This email and files attached to it are confidential. If you are not the intended recipient you are hereby notified that using, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited. If you have received this email in error please notify the sender and delete this email.
Back to the top