|
Carl,
Thanks for explanation and historical references :)
I'd rather save your answer handy.
/Victor
On 03/26/2015 09:29 PM, Carl Anderson wrote:
Victor,
The info you are looking for
is on https://wiki.eclipse.org/WTP_PMC_Defect_Review . The main issue is that any bug that has impact
outside of WTP needs PMC approval after M6. That includes new
features, API changes (not internal... public API), and any UI
changes that effect the translatable files. Those changes
need to be approved first by the project lead (or his
delegate), and then by the PMC, adding in whatever verbiage is
necessary for the PMC to understand what they are approving.
(Way back when, after RC1, some foolish WTP developer asked
for PMC approval on a behavior change. The PMC thought it was
just a bug fix and approved. Things got ugly when it affected
an adopter of WTP. So our process was changed to make it
clear that the PMC approval is for a specific reason in those
cases. And that foolish developer? Well, he went on to
become the WTP Releng project lead, and a member of the WTP
PMC!)
If all you are doing is fixing
bugs that do not have an external effect, then PMC approval is
not needed until RC1 is declared.
FWIW,
- Carl Anderson
WTP Releng project lead, and a
member of the WTP PMC
 "Victor V. Rubezhny" ---03/26/2015
01:44:23 PM---Hi, I have a number of bug fixes to merge into
JSDT master for Mars stream,
From: "Victor V. Rubezhny"
<vrubezhny@xxxxxxxxxx>
To: "General discussion of project-wide
or architectural issues." <wtp-dev@xxxxxxxxxxx>
Date: 03/26/2015 01:44 PM
Subject: [wtp-dev] Is PMC approval required
for non-UI bugs to merge after M6 is released?
Sent by: wtp-dev-bounces@xxxxxxxxxxx
Hi,
I have a number of bug fixes to merge into JSDT master for
Mars stream,
but I'm a bit "lost in translations"...
Once upon a time I read a doc (probably on wiki) that regulate
the
possibility of pushing the code into master depending on the
stage of a
project (When a PMC Approval is required for UI/Non-UI issues
and so
on). It looks like I've lost the URL to that document and
cannot find it
for some reason. Could anybody please send a link to such a
document if
it really exists?
Am I correct in that I don't need a PMC Approval for non-UI
fixes and I
can deliver these fixes even after M6 is declared (but before
the
declaration of M7?)?
The fixes I'd like to include into JSDT Mars stream are:
- https://bugs.eclipse.org/bugs/show_bug.cgi?id=387850 - Update to Rhino
1.7R4
- https://bugs.eclipse.org/bugs/show_bug.cgi?id=453700 - Incorrect
parentheses clean up in JS files
- probably few fixes provided by Gerrit contributions (I'm
reviewing
some fixes for Sonar FindBug issues at the moment)
All these fixes make no harm for UI, so they don't require to
change
translations, docs and so on.
And a minor question on Bug# 453700: This bug is included into
the
"Great Fixes for Mars" competition, but suddenly I've fixed it
by
myself... So, what should I do with it: wait for a possible
fix from
competitors until the competition is finished (May 6, 2015) or
push my
fix and cancel the issue from a competition (probably to
replace it with
another issue)?
Thanks in advance,
Victor Rubezhny,
JSDT
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev
|
