On 03/24/2015 07:35 PM, Victor V.
Rubezhny wrote:
On 03/23/2015 02:34 PM, Mickael
Istria wrote:
TL;DR: Being in master != being in
delivery for Mars.
On 03/23/2015 12:21 PM, Victor V. Rubezhny wrote:
I didn't merged the code in
master, since we still have few issues that blocks us from
doing it in Mars (I don't think we can get them fixed in
time for Mars, so it looks like we're missing Mars stream
with this contribution).
That's not a problem: we can have code in master without
shipping it on Mars, that's what I strongly believe is the best
approach for easier collaboration, and to avoid risk of
diverging branches.
IMHO, It's better to write your
suggestions here (in mailing list) first, because I'm going
to push another patch set into Gerrit ( https://git.eclipse.org/r/#/c/41693/
), so if you have some code comments to do then your
comments could be 'forgotten'. But still free to add
comments to the change.
Suggestion is that for a 1st integration in master, just include
the bundles, not the pom files, do not update other pom files,
feature.xml nor category.xml. So the code is there, people can
work on it, but not altering the build and delivery.
But this will not enable neither the building of Bower plug-ins,
nor running its JUnit tests then.
Not in a 1st time, we'll work on another commit to integrate it as
best in the build and delivery after code has moved to master. Let's
do it step by step, 1st step is to put code into master.
Then next iteration would be to see if we can build it easily,
include in the category.xml file as a separete entry, without
modifying the "regular" JSDT feature so it wouldn't get in Mars.
That would allow people who want to try it to get it from a p2
repository.
I can create a category for Bower IDE, but again: what will go
into this category in case we aren't adding the Bower plug-ins
into the build? It looks for me that we have to add the
bower-related plug-ins to pom.xml-s, to create a separated feature
for bower and then include that feature into site/pom.xml and
category.xml, but not to jsdt.feature/jsdt_sdk.feature.
I'd rather add an "Experiment/Incubation JSDT components" which
would include such a Bower feature.
About experimental stuff, there is also
https://git.eclipse.org/r/#/c/44029/ which is waiting for
review/merge. This is not meant to be part of Mars distribution
neither, and as you can see, it is built and provided as a separate
entry on the same update-site.
But
I'm not sure if bower plug-ins will not became 'installable by
default' in such case.
There is no such concept as "installable by default". If no existing
feature nor bundles links to Bower, nothing will install Bower
magically.
Please put the Bower-related code to master ASAP if you want a good
integration early. We don't want to have diverging branches,
separate sites to test Bower, and distinct builds.
|