|Re: [wtp-dev] JSDT facet gone missing in 3.0.4?|
Looking at this again - then if the only thing the facet framework is doing is logging that there is a missing thing which does not affect any behavior at all shouldn't this be traced instead of error'd ? I still find it really bad JSDT didn't fix this fully, but if the fix would be to lower the logging severity isn't that a better fix ?Well now you're dealing from the fallout of behavior where non-critical errors are flooding the Error Log despite nothing being really wrong. Some other people had previously complained about the flooding of the Error Log in similar situations in the past and "some discussion" ensued, but no changes were made. Now you're dealing with the fallout of the exact same problem and your solutions / suggestions include either changing a large number of plugin.xml files or re-instating a deprecated extension point (even if it does nothing) simply so that your framework doesn't flood the error log.I must disagree for this one ;) The poor handling is about the JSDT; it should either not have been added in the first place or not removed before 3.1 or removed completely and not half-done as here.I'm not trying to be crude or rude here (forgive me, I *am* from NYC), but others had complained about the behavior, were ignored, and your solutions don't seem to address the actual issue. The plugin.xml files shouldn't have to change. The old facet should not need to be re-instated. Your framework just shouldn't complain so much, and if it must, it should do it via Trace.I agree with Konstantin that getting warnings/errors about bad configuration is better than ignoring it by default. The solution for this would be that you could mark things explicitly as optional/don't error or somehow let JSDT or a seperate plugin state it want to be part of the aggregation(?)In any case, what is 3.0.4 adopters supposed to do with this bug ? Is there anything we can do to fix it ? We got a release coming up in March and would like to use 3.0.4 but want to be sure we don't flood users logswith these messages.
Back to the top