[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [wtp-dev] JSDT facet gone missing in 3.0.4?

How cute, but short of having extension points that never report errors due to invalid input, I don't see how this case could have been handled better. The extension point in question is specifically designed so that it works in aggregate. You put the relationship either close to the facet or close to the runtime driver, depending on which way the plugin/feature dependencies flow. 

Note that nothing is actually failing here. The system reports a problem with the extension in question and goes on. The other extensions and the rest of the system continue to work correctly.

There is some discussion about explicitly marking certain extensions as ok to ignore when referenced components are missing, but I don't see that ever being the default behavior. 


Oracle
Konstantin Komissarchik | Consulting Member of Technical Staff
Phone: +1 425 945 8445 | Mobile: +1 206 898 0611 
Oracle Eclipse Tooling
411 108th Ave NE, Suite 800 | Bellevue, WA 98004 
 

-----Original Message-----
From: Rob Stryker [mailto:rob.stryker@xxxxxxxxxx] 
Sent: Tuesday, February 03, 2009 8:49 PM
To: konstantin.komissarchik@xxxxxxxxxx; General discussion of project-wide or architectural issues.
Subject: Re: [wtp-dev] JSDT facet gone missing in 3.0.4?

Maybe this is just crazy talk, but perhaps a server or runtime type
expressing "support" for a facet type should not cause error messages
like this if the facet type is missing. I know, I know... I'm living in
a dream land... but in my thick empty skull I kinda have this notion
that "supporting" a facet isn't the same as requiring it.

But, I mean, I could be wrong. Maybe there's something in the China
water messing with my head. Crazy talk. ... Crazy.

;)

- Rob Stryker

Konstantin Komissarchik wrote:
> I just double-checked and despite what is said in Bug 243183, the JSDT facet is present in Ganymede SR1 (3.0.2) and in 3.0.3. It has been removed in the 3.1 HEAD stream for a few months now, but the change in the maintenance stream has happened fairly recently.
>
>
>> surprised by the number of plugin.xmls that now have to be updated to
>> prevent this error message.
>>
>
> This was the result of the desire to have the JSDT facet on by default when a user targets one of the runtimes that has drivers shipping with WTP. This meant that this facet had to be explicitly included in all the default facet sets for all the various server types. In my opinion, this would have been much better handled by leaving the facet off by default and having some way to unobtrusively tell the user that there is additional functionality available when the user goes to certain contexts. For instance, if the user opens a javascript file or you detect javascript in an html/jsp, you could put an "Enable advance JavaScript support" banner link across the top of the editor. That's just my two cents on this.
>
>
>> Even if the facet is added back into 3.0.4, is/will there be a mechanism
>> for deprecating or automatically migrating it out of 3.1 (by M6 if that's
>> the course of action we decide upon)?
>>
>
> That depends on what behavior you are after. There is an enhancement request (Bug 255038) that was recently opened that would allow facets to be marked as deprecated. In that case you leave the facet implementation in the code base, but because it is marked as deprecated it is not visible on projects that don't have it installed already. Project metadata is not modified automatically. Other approaches are possible as well, of course.
>
>
> Oracle
> Konstantin Komissarchik | Consulting Member of Technical Staff
> Phone: +1 425 945 8445 | Mobile: +1 206 898 0611
> Oracle Eclipse Tooling
> 411 108th Ave NE, Suite 800 | Bellevue, WA 98004
>
>
> -----Original Message-----
> From: wtp-dev-bounces@xxxxxxxxxxx [mailto:wtp-dev-bounces@xxxxxxxxxxx] On Behalf Of Nitin Dahyabhai
> Sent: Tuesday, February 03, 2009 6:17 AM
> To: wtp-dev@xxxxxxxxxxx
> Subject: Re: [wtp-dev] JSDT facet gone missing in 3.0.4?
>
> Looks like it was removed in 3.0.2 through bug 243183, and at least
> noticed at the latest from bug 21928, but not actually removed from the
> server tools plug-ins.  I regret how poorly this was handled, and am
> surprised by the number of plugin.xmls that now have to be updated to
> prevent this error message.
>
> Even if the facet is added back into 3.0.4, is/will there be a mechanism
> for deprecating or automatically migrating it out of 3.1 (by M6 if that's
> the course of action we decide upon)?
>
> Regards,
> ---
> Nitin Dahyabhai
> Eclipse WTP Source Editing
> IBM Rational
>
> _______________________________________________
> wtp-dev mailing list
> wtp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/wtp-dev
>
> _______________________________________________
> wtp-dev mailing list
> wtp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/wtp-dev
>