Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [websocket-dev] Removing restrictions on direct commits

I personally really like having the restrictions. If for nothing else it at least allows a quick review of your work by someone else to catch mistakes.


Paul Nicolucci

On Tue, Nov 2, 2021, 12:29 PM Mark Thomas <markt@xxxxxxxxxx> wrote:

In approx 24 hours time I intend to request that the branch restrictions
that prevent committers committing directly to the master branch and
those that require every PR to be reviewed before merge are removed.

My reasoning is as follows:
- I have seen the benefits of these restrictions not being present in EL
- I'm expecting a number of non-substantive changes will be required to
   successfully complete the release process and PR + review for all of
   them will significantly slow us down
- Committers are perfectly capable of determining which changes need a
   PR and review and which can be made directly - and if they get it
   wrong changes can easily be reverted

I was intending to propose this change after the Jakarta 10 release but
on reflection, I think the sooner, the better.

Thoughts? Comments? Objections?

websocket-dev mailing list
To unsubscribe from this list, visit

Back to the top