[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [virgo-dev] com.springsource.*

(Please see bottom of msg, that's the important part.)

On Feb 14, 2012, at 11:38 AM, Glyn Normington wrote:

com.springsource.json v 1.0.1 is used in the Virgo system verification tests here:

Since this is downloaded only at build time, no CQ is required. (I have an email from the IP team on file confirming the general principle of CQs not being required for build-time downloads that are not needed by downstream consumers of Virgo.)

Yep, I had a similar issue and EMO was ok w/ it.

com.springsource.org.antlr-3.0.1.jar is checked in to the system verification tests repo. There is a "works with" CQ 4139 for this, but I don't think that covers checking in the JAR, so there was an oversight there. I've raised bug 371531to correct this.

Is this only used for supporting tooling or somewhere else? If the former see below, we may not need it.

2. Are they covered under an existing CQ?

See above.

  b) What is the provenance for this code? Doe the com.springsource.json contain springsource code and/or org.json code? When I explode jar, there is no license information in the jar itself.

com.springsource.json v 1.0.1 is, I think, 100% SpringSource code:

com.springsource.org.antlr-3.0.1.jar is ANTLR code with the addition of a generated manifest from SpringSource. See:

  c) Where is the source code, and where are the built?

The com.springsource.json v 1.0.1 source code is not available at the above link, but I don't think that's relevant since no CQ is needed.

Has it actually been donated already then?

For ANTLR 3.0.1, see CQ 4139.

Yeah, I think ANTLR is just out of the picture as we can't do a works with here. And since it looks like com.springsource.json is dependent on that, then that is out as well for inclusion in an Eclipse project. :(

So that's the bad news. The good news is that Leo and I have had a closer look and it appears that it wouldn't be that hard to just tear this all out. It looks like it's all there just to do some straightforward json parsing, which we _should_ be able to replace, certainly in less time than it would take to handle the IP engineering issues. :)