Re: [tycho-user] FeatureXmlTransformer.expandReferences() and Platform F

["Sievers, Jan" <jan.sievers@xxxxxxx>]

I don't think I have enough details to meaningfully discuss here.
if you think it's a bug, open one with a sample project along with desired vs observed behaviour and we can follow up there.

Regards
Jan

> -----Original Message-----
> From: tycho-user-bounces@xxxxxxxxxxx [mailto:tycho-user-bounces@xxxxxxxxxxx]
> On Behalf Of Eike Stepper
> Sent: Mittwoch, 1. Juli 2015 11:42
> To: tycho-user@xxxxxxxxxxx
> Subject: Re: [tycho-user] FeatureXmlTransformer.expandReferences() and
> Platform Filters
> 
> Hi Jan,
> 
> Thank you for your reply. Please see my comments below...
> 
> Cheers
> /Eike
> 
> ----
> http://www.esc-net.de
> http://thegordian.blogspot.com
> http://twitter.com/eikestepper
> 
> 
> 
> Am 01.07.2015 um 10:01 schrieb Sievers, Jan:
> > if the feature includes fragments for two environments, both must be
> available at build time, otherwise the feature would be incomplete.
> That doesn't make sense to me and it doesn't seem in line with PDE itself. I
> just tried to export that feature both with
> and without the other (unapplicable) fragment. It works perfectly in both
> cases and produces the exact same result.
> 
> I think Tycho should also just skip the PluginRefs that have environment
> filters attached that don't match the current
> build target environment(s).
> 
> > this is different from install time where non-applicable environments are
> ignored when installing the feature.
> Why should it be different?
> 
> >
> > I don't know the details of your build but looks to me like if you want to
> build the feature, both environments must be configured.
> >
> > Otherwise we'd need to know more details about
> >
> >> the build always fails if one (and not all) environments are being built
> > Regards
> > Jan
> >
> >> -----Original Message-----
> >> From: tycho-user-bounces@xxxxxxxxxxx [mailto:tycho-user-
> bounces@xxxxxxxxxxx]
> >> On Behalf Of Eike Stepper
> >> Sent: Dienstag, 30. Juni 2015 13:43
> >> To: tycho-user@xxxxxxxxxxx
> >> Subject: [tycho-user] FeatureXmlTransformer.expandReferences() and
> Platform
> >> Filters
> >>
> >> Hi,
> >>
> >> Our (Oomph) build contains some Windows-specific native fragments
> (different
> >> ones for 32 bit and 64 bit). Unfortunately
> >> the build always fails if one (and not all) environments are being built:
> >>
> >> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-packaging-
> >> plugin:0.23.0:package-feature (default-package-feature)
> >> on project org.eclipse.oomph.setup.core: Execution default-package-feature
> of
> >> goal
> >> org.eclipse.tycho:tycho-packaging-plugin:0.23.0:package-feature failed:
> >> eclipse-plugin artifact with ID
> >> "org.eclipse.oomph.jreinfo.win32.x86" and version matching "0.0.0" was not
> >> found in the target platform -> [Help 1]
> >>
> >> The feature that pulls in the two fragments and the fragments themselves
> >> (both in MANIFEST.MF and pom.xml) specify the
> >> correct environment filters. So I looked at
> >>
> org.eclipse.tycho.packaging.FeatureXmlTransformer.expandReferences(Feature,
> >> TargetPlatform) and to me it seems that methods like pluginRef.getArch()
> are
> >> not called to determine whether the plugin
> >> reference applies to the current environment or not.
> >>
> >> Am I missing something or is that a bug?
> >>
> >> Cheers
> >> /Eike
> >>
> >> ----
> >> http://www.esc-net.de
> >> http://thegordian.blogspot.com
> >> http://twitter.com/eikestepper
> >>
> >>
> >>
> >> _______________________________________________
> >> tycho-user mailing list
> >> tycho-user@xxxxxxxxxxx
> >> To change your delivery options, retrieve your password, or unsubscribe
> from
> >> this list, visit
> >> https://dev.eclipse.org/mailman/listinfo/tycho-user
> 
> 
> _______________________________________________
> tycho-user mailing list
> tycho-user@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/tycho-user