[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [tycho-user] jgit timestamp provider ignores local changes
|
On Tue, Mar 5, 2013 at 10:28 AM, Mickael Istria
<mistria@xxxxxxxxxx> wrote:
Hi all,
For our project, I gave a try to
http://wiki.eclipse.org/Tycho/Reproducible_Version_Qualifiers . It's
working well, but in the case a local change happen on the module,
the timestamp provider doesn't detect it and still uses timestamp of
the latest commit. So in the end, we can have several different
artifacts (with different content) using the same fully-qualified
versions, built on the same machine. This seems to me totally
dangerous since we expect OSGi bundles with same qualifiers to
contain the same thing. Here we cannot rely any more on qualified
version to compare bundles.
This is pretty common use-case that running a "mvn verify" before a
commit and then generating multiple artifacts with same version and
different content, so it's not a corner-case.
Ideally, I would have expected the git timestamp provider to set the
timestamp to the current build timestamp in case it detects a local
change. What would you think of this behaviour? Should I open a
feature request?
I know for what we use it for (the platform build) that we expect the current behaviour (tied to commit timestamp, not filesystem changes). But maybe a "track filesystem changes" option, as long as it was off by default (or really easy to disable globally)
PW
--
Paul Webster
Hi floor. Make me a sammich! - GIR
