[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] CQ for snappy java

I can confirm that, just built the tycho demo projects and the findbugs jar was not downloaded.

Thanks!
martin

-----UrsprÃngliche Nachricht-----
Von: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] Im Auftrag von Cornelius Dirmeier
Gesendet: Freitag, 22. Mai 2015 09:55
An: Tycho developers list
Betreff: Re: [tycho-dev] CQ for snappy java

Findbugs JSR 305 is not source retention (I think it is runtime) but that does not matter. As long as the dependency is marked as 'provided' it should not be downloaded by maven. The runtime will not fail if there are are missing annotations even if those have retention runtime.


Cornelius Dirmeier

________________________________________
Von: tycho-dev-bounces@xxxxxxxxxxx <tycho-dev-bounces@xxxxxxxxxxx> im Auftrag von Sievers, Jan <jan.sievers@xxxxxxx>
Gesendet: Freitag, 22. Mai 2015 09:25
An: Tycho developers list
Betreff: Re: [tycho-dev] CQ for snappy java

> The versions we want to proceed, plexus-archiver v2.10.1 and the 
> plexus-io
> v2.6 do have a depenency to com.google.code.findbugs.jsr305 v3.0.0 
> with the scope "provided".

you need to find out if this is needed at runtime (i.e. when someone runs a Tycho build, is this jar being downloaded by maven into the local maven repo) Did not look into the details but it could be these are source retention only annotations so they are really not needed at runtime.
In case it's downloaded but actually not used, you may want to try using maven dependency exclusions to force it not being used so we could save this CQ.

Jan


> -----Original Message-----
> From: tycho-dev-bounces@xxxxxxxxxxx 
> [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of SCHREIBER.Martin
> Sent: Freitag, 22. Mai 2015 08:11
> To: Tycho developers list
> Subject: Re: [tycho-dev] CQ for snappy java
>
> Thanks Jan!
>
> I had withdrawn the CQs for the depenency chain of plexus-archiver 
> v3.0
> ([1]..[3]) that had not already been fully approved.
>
> The versions we want to proceed, plexus-archiver v2.10.1 and the 
> plexus-io
> v2.6 do have a depenency to com.google.code.findbugs.jsr305 v3.0.0 
> with the scope "provided".
> Do I have to file a CQ for provided artifacts as well?
> If not, we just have to file a CQ for plexus-io and plexus-archiver, 
> all other transitive dependencies are already approved.
>
> Thanks
> Martin
>
>
> [1] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=9400
> [2] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=9401
> [3] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=9404
>
>
>
> -----UrsprÃngliche Nachricht-----
> Von: tycho-dev-bounces@xxxxxxxxxxx 
> [mailto:tycho-dev-bounces@xxxxxxxxxxx] Im Auftrag von Sievers, Jan
> Gesendet: Donnerstag, 21. Mai 2015 16:32
> An: Tycho developers list
> Betreff: Re: [tycho-dev] CQ for snappy java
>
> http://search.maven.org is the canonical search for maven central you 
> want to use.
>
> Jan
>
> > -----Original Message-----
> > From: tycho-dev-bounces@xxxxxxxxxxx
> > [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of SCHREIBER.Martin
> > Sent: Donnerstag, 21. Mai 2015 15:33
> > To: Tycho developers list
> > Subject: Re: [tycho-dev] CQ for snappy java
> >
> > Sorry, I messed up the versions in the email.
> > I did the test with plexus-archiver 2.10 and plexus-io 2.6. I used 
> > archiver
> > 2.10 and not 2.10.1 because I could not find 2.10.1 on the maven 
> > repository [1], but I can do another build with 2.10.1.
> >
> > If this works as well, I will abandon the CQs that are not needed 
> > for
> > 2.10.1 and create new ones.
> >
> > Thanks
> > martin
> >
> > [1]
> > http://mvnrepository.com/artifact/org.codehaus.plexus/plexus-archive
> > r
> >
> >
> > -----UrsprÃngliche Nachricht-----
> > Von: tycho-dev-bounces@xxxxxxxxxxx
> > [mailto:tycho-dev-bounces@xxxxxxxxxxx] Im Auftrag von Sievers, Jan
> > Gesendet: Donnerstag, 21. Mai 2015 12:58
> > An: Tycho developers list
> > Betreff: Re: [tycho-dev] CQ for snappy java
> >
> > I'd propose to use latest 2.x plexus-archiver i.e. 2.10.1 (it's more 
> > up to date than 3.0 anyway) as advised in
> > https://github.com/codehaus-plexus/plexus-archiver/issues/3
> >
> > to avoid the snappy-java license issue altogether as it's unclear to 
> > me how this will play out.
> >
> > Unfortunately that would mean file new CQs and abandon the old ones.
> >
> > Any reason you used plexus-archiver 2.6 now instead of latest 2.10.1?
> >
> > Regards
> > Jan
> >
> >
> >
> > > -----Original Message-----
> > > From: tycho-dev-bounces@xxxxxxxxxxx 
> > > [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of 
> > > SCHREIBER.Martin
> > > Sent: Donnerstag, 21. Mai 2015 12:43
> > > To: Tycho developers list
> > > Subject: Re: [tycho-dev] CQ for snappy java
> > >
> > > Thanks Jan and Igor for your comments on this issue and for 
> > > creating issues in plexus and jnappy-java!
> > >
> > > I was able to test the bugfix for the original issue [1] with 
> > > plexus-archiver
> > > 2.6 which does not need snappy-java and it solves the issue.
> > > So we have 2 possibilities to proceed:
> > >
> > > 1) Withdraw the CQs for plexus-archiver 3.0 and its dependencies 
> > > and create new ones for v2.6 or
> > > 2) Wait till we know if it is really a license issue or till the 
> > > plexus developers and/or jnappy java developers fix the issue.
> > >
> > > Thanks
> > > Martin
> > >
> > > [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=461974
> > >
> > >
> > > -----UrsprÃngliche Nachricht-----
> > > Von: tycho-dev-bounces@xxxxxxxxxxx 
> > > [mailto:tycho-dev-bounces@xxxxxxxxxxx] Im Auftrag von Sievers, Jan
> > > Gesendet: Mittwoch, 20. Mai 2015 13:43
> > > An: Tycho developers list
> > > Betreff: Re: [tycho-dev] CQ for snappy java
> > >
> > > and https://github.com/codehaus-plexus/plexus-archiver/issues/3
> > >
> > > > -----Original Message-----
> > > > From: tycho-dev-bounces@xxxxxxxxxxx 
> > > > [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Sievers, Jan
> > > > Sent: Mittwoch, 20. Mai 2015 13:35
> > > > To: Tycho developers list
> > > > Subject: Re: [tycho-dev] CQ for snappy java
> > > >
> > > > right. I also submitted
> > > > https://github.com/xerial/snappy-java/issues/113
> > > >
> > > > Jan
> > > >
> > > > From: tycho-dev-bounces@xxxxxxxxxxx 
> > > > [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Igor 
> > > > Fedorenko
> > > > Sent: Mittwoch, 20. Mai 2015 12:56
> > > > To: tycho-dev@xxxxxxxxxxx
> > > > Subject: Re: [tycho-dev] CQ for snappy java
> > > >
> > > > Have you reported the issue to plexus-archiver developers. I 
> > > > don't believe they can use GPL'ed code either, so at very least 
> > > > this will help them maintain their IP policy.
> > > >
> > > > --
> > > > Regards,
> > > > Igor
> > > >
> > > >
> > > > On Wed, May 20, 2015, at 01:58 AM, SCHREIBER.Martin wrote:
> > > > Hi,
> > > >
> > > > for resolving the bug regarding invalid zip files for very large 
> > > > repositories [1], I created different CQs for updating the 
> > > > plexus-archiver and all itâs depenencies.
> > > > One of the dependencies is snappy-java.
> > > > The new version of snappy-java seems to contain stuff that is 
> > > > not compatible with the EPL (see CQ [2]). It might not be an 
> > > > issue since we do not ship snappy-java in any artifacts but I am 
> > > > not sure what the next steps regarding the CQs should be. So can 
> > > > someone help me out there
> > > please.
> > > >
> > > > Thanks
> > > > Martin
> > > >
> > > > [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=461974c
> > > > [2] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=9404
> > > >
> > > > p.s. the other CQs needed for the bugfix are approved 
> > > > _______________________________________________
> > > > tycho-dev mailing list
> > > > tycho-dev@xxxxxxxxxxx
> > > > To change your delivery options, retrieve your password, or 
> > > > unsubscribe from this list, visit 
> > > > https://dev.eclipse.org/mailman/listinfo/tycho-dev
> > > >
> > > > _______________________________________________
> > > > tycho-dev mailing list
> > > > tycho-dev@xxxxxxxxxxx
> > > > To change your delivery options, retrieve your password, or 
> > > > unsubscribe from this list, visit 
> > > > https://dev.eclipse.org/mailman/listinfo/tycho-dev
> > > _______________________________________________
> > > tycho-dev mailing list
> > > tycho-dev@xxxxxxxxxxx
> > > To change your delivery options, retrieve your password, or 
> > > unsubscribe from this list, visit 
> > > https://dev.eclipse.org/mailman/listinfo/tycho-dev
> > > _______________________________________________
> > > tycho-dev mailing list
> > > tycho-dev@xxxxxxxxxxx
> > > To change your delivery options, retrieve your password, or 
> > > unsubscribe from this list, visit 
> > > https://dev.eclipse.org/mailman/listinfo/tycho-dev
> > _______________________________________________
> > tycho-dev mailing list
> > tycho-dev@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or 
> > unsubscribe from this list, visit 
> > https://dev.eclipse.org/mailman/listinfo/tycho-dev
> > _______________________________________________
> > tycho-dev mailing list
> > tycho-dev@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or 
> > unsubscribe from this list, visit 
> > https://dev.eclipse.org/mailman/listinfo/tycho-dev
> _______________________________________________
> tycho-dev mailing list
> tycho-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or 
> unsubscribe from this list, visit 
> https://dev.eclipse.org/mailman/listinfo/tycho-dev
> _______________________________________________
> tycho-dev mailing list
> tycho-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or 
> unsubscribe from this list, visit 
> https://dev.eclipse.org/mailman/listinfo/tycho-dev
_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/tycho-dev


----------------------------------------------------------------------------------

Faktor Zehn AG      Sitz der Gesellschaft: Muenchen   Registernummer: HRB 169990 Registergericht: Amtsgericht Muenchen
Vorstand: Dr. Florian Schwandt (Vorsitz), Joerg Renger
Aufsichtsratsvorsitzender: Martin Hinz

_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/tycho-dev