Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[tycho-dev] FW: Gerrit review process

-----Original Message-----
From: Oberlies, Tobias 
Sent: Montag, 23. April 2012 16:23
To: 'Igor Fedorenko'
Cc: Sievers, Jan
Subject: Gerrit review process

I would propose that we do the rebases ourselves, e.g. 
* when starting the review of a change (if there have been relevant concurrent changes), and
* directly before committing it.

The contributors can't know when we are going to review their changes, i.e. when it makes sense to do a rebase, and therefore probably would do it too often. And with our policy to require a Change-Id, a rebase is usually no effort at all.

The rebase will change the commiter, but leave the author unchanged. Only the latter is relevant for the IP log.


> -----Original Message-----
> From: Igor Fedorenko [mailto:igor@xxxxxxxxxxxxxx]
> Sent: Montag, 23. April 2012 16:07
> To: Oberlies, Tobias
> Cc: Sievers, Jan
> Subject: Re: [Bug 371620] Enable Gerrit for tycho
> What do we do for changes submitted by external developers, like
> ? Do we ask them to do rebase&push
> or do we do this ourselves? In the latter case, will the commit still be
> attributed to the original author?
> --
> Regards,
> Igor
> On 12-04-23 5:49 AM, Oberlies, Tobias wrote:
> > ... and for the master branch, it is refs/for/master
> >
> > Just to be sure: Igor, are you aware that your change
> is not yet submitted (i.e. merged to
> the master branch)? To get it in, you need to
> > * rebase it to origin/master
> > * push it to refs/for/master again
> > * vote on the change
> > * submit it
> >
> > Best regards
> > Tobias
> >

Back to the top