Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] [Tycho Users] please test staged tycho 0.11.0

I've attached sample project and proposed fix to the bugzilla.

Basically, Tycho [0.9.0, 0.11.0-SNAPSHOT] assumes jars.extra.classpath
entries point at *classpath* entries of the target bundle and the fix is
to make it use *any* existing bundle entry. The fix affects consuming
end only and does not required any additional metadata from the
referenced bundle.

--
Regards,
Igor

On 11-04-01 10:21 AM, Sievers, Jan wrote:
hm. You mean you want to parse build.properties of external bundles and also include jars.extra.classpath from there?

A concrete example would help for this discussion.

The problem I see here is that build.properties is essentially a design-time only file, so it's generally not included in the runtime bundle jar.
So I wonder if this information is available in general for external bundles at all.

Also, if I use jars.extra.classpath in my bundle and actually require these jars to be on the classpath for another bundle to compile against me, something is wrong with my bundle classpath IMHO.

So either the providing bundle puts the jars on Bundle-ClassPath or all users are required to add a jars.extra.classpath with the additional entries themselves.
This is possible with since Pascal's patch
https://github.com/sonatype/sonatype-tycho/commit/c852becfa2e197874872fa2ff102b2efd2d9f9c0

,so e.g.

jars.extra.classpath=platform:plugin/org.my.example.bundle/path/to/nested.jar,platform:plugin/org.my.example.bundle/path/to/another/nested.jar

solves the problem on the consumer side. What do you think?

Jan

-----Original Message-----
From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
Sent: Freitag, 1. April 2011 15:47
To: tycho-dev@xxxxxxxxxxx
Cc: tycho-users@xxxxxxxxxxxxxxxxxx
Subject: Re: [tycho-dev] [Tycho Users] please test staged tycho 0.11.0

I tested 0.11.0 some more last night and ran into [1] with one of our
older builds, which was still using Tycho 0.8.0 (yeah, it's pretty old
;-) ). The fix is relatively straightforward and I wonder if I should
restage 0.11.0 once more to include it.

What do you think?

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=341570

--
Regards,
Igor

On 11-03-31 12:55 PM, Igor Fedorenko wrote:
I restaged tycho 0.11.0 to include this change. New staging repository
url is [1] and dropped the old repository. Remember to clean
org/sonatype/tycho in your local Maven repository force Maven pick
restaged build. If no new problems are found, we will promote this build
to final 0.11.0 some time next week.

[1] https://repository.sonatype.org/content/repositories/sonatype_org-031/

--
Regards,
Igor

On 11-03-30 09:31 AM, Sievers, Jan wrote:
done.
https://github.com/sonatype/sonatype-tycho/commits/tycho-0.11.x

Regards
Jan

From: Matthias Sohn [mailto:matthias.sohn@xxxxxxxxxxxxxx]
Sent: Mittwoch, 30. März 2011 14:49
To: tycho-users@xxxxxxxxxxxxxxxxxx
Cc: Sievers, Jan
Subject: Re: [Tycho Users] please test staged tycho 0.11.0

2011/3/29 Sievers, Jan<jan.sievers@xxxxxxx>
TYCHO-421 is probably the culprit here...

working on a patch.

tried your patch on top of tycho 0.12-snapshot and this fixes the
problem for egit.
So please cherry-pick that for 0.11

--
Matthias


Jan

From: Matthias Sohn [mailto:matthias.sohn@xxxxxxxxxxxxxx]
Sent: Dienstag, 29. März 2011 17:16
To: tycho-users@xxxxxxxxxxxxxxxxxx
Cc: Igor Fedorenko
Subject: Re: [Tycho Users] please test staged tycho 0.11.0
2011/3/26 Igor Fedorenko<ifedorenko@xxxxxxxxxxxx>
This is primarily a bugfixing and internal refactoring release.

Please test this new release and report any problems you find either on
the mailing list on in jira. We will promote release to Maven central
repository sometime at the end of the next week if no major regressions
are found.

Staged repository

https://repository.sonatype.org/content/repositories/sonatype_org-002/

Full list of changes since Tycho 0.10.0

https://issues.sonatype.org/secure/ReleaseNote.jspa?projectId=10030&version=10874


This works for EGit except the swtbot tests.

I first ran into an encoding problem with maven pmd plugin we use to
detect copy and paste reuse.
The encoding problem wasn't visible with tycho 0.10 as tycho 0.10
didn't respect source paths
from build.properties hence PMD didn't find any sources at all (and
consequently also didn't
detect any problems :-).

The encoding problem was caused by UTF-8 BOM in some sources.

The org.eclipse.egit.ui.test bundle can't run the swtbot tests
anymore. It seems tycho lost
the ability to accept version ranges in dependencies for running
bundle tests.
(dependency section of maven-osgi-test-plugin. It only accepts 0.0.0
or exact version match.
Version ranges lead to a parsing error :

[ERROR] Failed to execute goal
org.sonatype.tycho:maven-osgi-test-plugin:0.11.0:test (default-test)
on project org.eclipse.egit.ui.test: Execution default-test of goal
org.sonatype.tycho:maven-osgi-test-plugin:0.11.0:test failed:
org.eclipse.equinox.p2.core.ProvisionException: No solution found
because the problem is unsatisfiable. ->  [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
execute goal org.sonatype.tycho:maven-osgi-test-plugin:0.11.0:test
(default-test) on project org.eclipse.egit.ui.test: Execution
default-test of goal
org.sonatype.tycho:maven-osgi-test-plugin:0.11.0:test failed:
org.eclipse.equinox.p2.core.ProvisionException: No solution found
because the problem is unsatisfiable.
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:225)

at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)

at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)

at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)

at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)

at
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)

at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)

at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:319)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:534)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)

at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

at java.lang.reflect.Method.invoke(Method.java:597)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)

at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)

at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)

at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
default-test of goal
org.sonatype.tycho:maven-osgi-test-plugin:0.11.0:test failed:
org.eclipse.equinox.p2.core.ProvisionException: No solution found
because the problem is unsatisfiable.
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:116)

at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)

... 19 more
Caused by: java.lang.RuntimeException:
org.eclipse.equinox.p2.core.ProvisionException: No solution found
because the problem is unsatisfiable.
at
org.sonatype.tycho.p2.impl.resolver.ProjectorResolutionStrategy.resolve(ProjectorResolutionStrategy.java:100)

at
org.sonatype.tycho.p2.impl.resolver.P2ResolverImpl.resolveProject(P2ResolverImpl.java:354)

at
org.sonatype.tycho.p2.impl.resolver.P2ResolverImpl.resolveProject(P2ResolverImpl.java:319)

at
org.sonatype.tycho.p2.facade.P2TargetPlatformResolver.doResolvePlatform(P2TargetPlatformResolver.java:462)

at
org.sonatype.tycho.p2.facade.P2TargetPlatformResolver.resolvePlatform(P2TargetPlatformResolver.java:151)

at
org.codehaus.tycho.osgitest.TestMojo.createEclipseInstallation(TestMojo.java:368)

at org.codehaus.tycho.osgitest.TestMojo.execute(TestMojo.java:342)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:107)

... 20 more
Caused by: org.eclipse.equinox.p2.core.ProvisionException: No solution
found because the problem is unsatisfiable.
... 28 more


--
Matthias



_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-dev
_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-dev


Back to the top