Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tracecompass-dev] Adding 'rank' column to traces

Hi Matthew,

Wow, I didn't know about the hover trick, cool :-)

The use case is primarily a QOL improvement for discussions. Using your screenshot above, if I wanted to tell someone to take a look at the line you have hovered (before it got hovered), I would have to say "look at point four four zero one seventy two, close to the bottom" or similar. Instead, I would rather say "look at line 8" and immediately everyone in the call would know what I'm talking about. Over lengthy discussions this is a QOL improvement we've identified.

This also relates to the Bookmark bug I posted. If a non-default description is used, the rank is the only aspect identifying where the bookmark is in the log. But the rank means little to me since I've never seen which timestamps correspond to which ranks. If there was a rank column always in sight, I would already have an idea where I am in the log at all times, so when "rank 230313" is in a bookmark I would have some idea where it is. Again, this is not a big problem, just a QOL improvement.

Additionally, if someone looked at the trace log previously and has an interesting event, instead of communicating and searching for the lengthy / specific timestamp, the "Rank" column would allow just searching for the rank the other dev found (basically a "go to line" function).

I can't say I fully understand what is happening in the offset screenshot, but when I get some time I'll take a look more at this feature.

Thanks,
Zach

On Tue, Jan 19, 2021 at 7:42 PM tracecompass developer discussions <tracecompass-dev@xxxxxxxxxxx> wrote:
Hi Zach,

I just want to be sure you know about the tooltip for ranks. If you hover over the bookmark column, the tooltip shows the rank of the event. Event ranks are a little odd btw, consider we can merge traces so ranks will zip each other up. Also you can offset times, changing the ranks.



Patches are always welcome, and we would love to see what use cases you are facing too.

If you wish to write a patch, here's our guide, it should be up to date.
You can use the code from these repositories to experiment, test, build, create patches, issue pull requests, etc. This project uses Gerrit Code Review; please see contributing via Gerrit.
Thank you!

Matthew

From: tracecompass-dev <tracecompass-dev-bounces@xxxxxxxxxxx> on behalf of tracecompass developer discussions <tracecompass-dev@xxxxxxxxxxx>
Sent: Tuesday, January 19, 2021 11:06 AM
To: tracecompass-dev@xxxxxxxxxxx <tracecompass-dev@xxxxxxxxxxx>
Subject: [tracecompass-dev] Adding 'rank' column to traces
 
Hi,

I am interested in having a 'Rank' column to show the equivalent of line numbers in a trace log e.g. so that while collaborating with other developers we can just refer to "line 300" or similar, instead of timestamps. The bookmarks view already shows rank, but I do not see a way to view the rank in the log itself.

If this feature doesn't yet exist, is there a way to submit such feature requests?

Additionally, if you have any pointers for implementing this feature I could take a look at it and see if it is feasible to attempt it myself. In particular I am interested in having this for LTTng logs and am not sure if special requirements are needed for other types of logs.

Best,
Zach
_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/tracecompass-dev

Back to the top