Re: [tracecompass-dev] Trace filters not working in Eclipse Oxygenreleas

["David Wootton" <dwootton@xxxxxxxxxx>]

Patrick
The filter did not work with just a TRACETYPE node. When I debugged TmfFilterTraceTypeNode.matches(), it looks like this was because the trace type ID was null.

That appears to because I was calling TmfTrace.initTrace(IResource, String, Class) instead of TmfTrace.initTrace(IResource, String, Class, String, String) and where the initTrace method I was calling did not set fTraceTypeId.

I changed my code to call the second initTrace method, passing an empty string for name for now and the trace id matching what was in my extension in plugin.xml and the filter with only a TRACETYPE node works as well as the filter with a TRACETYPE node and then a MATCHES node as a child of the TRACETYPE node, so this appears to be the problem.

I'm not sure what to pass for the name parameter. It looks like it's expected to be a pathname to the trace but I'm not sure, and I don't know if it matters.

Dave

Patrick Tasse ---11/07/2017 11:58:18 AM---Hi Dave, Looks like it could be an issue with the TRACETYPE node? Could you debug

From: Patrick Tasse <patrick.tasse@xxxxxxxxx>
To: tracecompass developer discussions <tracecompass-dev@xxxxxxxxxxx>
Date: 11/07/2017 11:58 AM
Subject: Re: [tracecompass-dev] Trace filters not working in Eclipse Oxygen release
Sent by: tracecompass-dev-bounces@xxxxxxxxxxx

---

Hi Dave,

Looks like it could be an issue with the TRACETYPE node? Could you debug TmfFilterTraceType.matches()?

Does it work if you only have a TRACETYPE node in your filter (if all is correct then it should match all events in the trace)?

Does your own trace return the same trace type ID that is defined in the org.eclipse.linuxtools.tmf.core.tracetype extension in plugin.xml?

Patrick


On Mon, Nov 6, 2017 at 5:50 PM, David Wootton <dwootton@xxxxxxxxxx> wrote:

Matthew
I thought this problem went away, since suddenly filters seemed to start working for me after my last email. However, today the problem came back, and I realize now that it may be related to how I create the filter.

If I create a filter where the immediate child under the filter node in the filter view is a MATCHES operator, where I have to still specify a type and an aspect as part of that node, then the filter works correctly. Also, the breakpoint you suggested at TmfFilterNode#matches hits and sometimes returns true and other times false, which makes sense since not every row matches the field value I specified in the filter.

If I create a filter where the immediate child under the filter node is a TRACETYPE operator, where I specify the same type and aspect, and then a MATCHES node as a child of the TRACETYPE node with the same match value text (which should result in the same matching rows), then the filter result is zero rows match, and the breakpoint at TmfFilterNode#matches never hits at all.

I have my own trace type for the trace generated by my plugin, and when I select that, I get a dropdown list of aspect names to pick from that looks correct.

I'm not sure now which method I used to create working filters using the Neon release last year, and don't know if my second sequence to create a filter ever worked.

Dave

Matthew Khouzam ---10/26/2017 12:51:35 PM---Could you try using a breakpoint on "TmfFilterNode#matches", that is where the meat of the filters r

From: Matthew Khouzam <matthew.khouzam@xxxxxxxxxxxx>
To: <tracecompass-dev@xxxxxxxxxxx>
Date: 10/26/2017 12:51 PM
Subject: Re: [tracecompass-dev] Trace filters not working in Eclipse Oxygen release
Sent by: tracecompass-dev-bounces@xxxxxxxxxxx


---




Could you try using a breakpoint on "TmfFilterNode#matches", that is
where the meat of the filters resides.


On 17-10-26 11:55 AM, David Wootton wrote:
>
> Matthew
>
> There's not much I can post. I could post one of my aspects, but I'm
> seeing the problem with the 'Event type' column in the trace editor
> view, where the aspect definition is obtained by calling
> TmfBaseAspects.getEventTypeAspect() as well.
>
> I'm using the trace editor view and the filter view as-is in my
> plugins where I do not extend those classes. The filter view is
> referenced in my plugin using the view identifier
> org.eclipse.linuxtools.tmf.ui.views.filter which did work last year.
>
> My work was mainly in coding the class that loads my trace file into
> the viewer, the state system extensions and extension of the
> CallStackView class, where I don't think I have done anything that
> could interfere with the workings of the trace editor view or the
> filtering mechanism, where the only likely candidate is if I've done
> something to the state system.
>
> If you're not aware of any code changes from Neon to Oxygen, then I
> must have done something to cause this.
>
> If you have suggestions where I might try to look at/debug source
> code, that would be appreciated. Other than filtering, the trace
> editor view seems to be working correctly for me.
>
> Dave
>
> Inactive hide details for Matthew Khouzam ---10/26/2017 09:54:08
> AM---Hi Dave, I really hate to say this, it works for me...Matthew
> Khouzam ---10/26/2017 09:54:08 AM---Hi Dave, I really hate to say
> this, it works for me...
>
> From: Matthew Khouzam <matthew.khouzam@xxxxxxxxxxxx>
> To: <tracecompass-dev@xxxxxxxxxxx>
> Date: 10/26/2017 09:54 AM
> Subject: Re: [tracecompass-dev] Trace filters not working in Eclipse
> Oxygen release
> Sent by: tracecompass-dev-bounces@xxxxxxxxxxx
>
> ------------------------------------------------------------------------

>
>
>
> Hi Dave,
>
> I really hate to say this, it works for me...
>
> Are you using things that you can share online? Maybe we can see your
> aspect?
>
> BR
>
> Matthew
>
>
> On 17-10-26 09:05 AM, David Wootton wrote:
> >
> > Hi
> > My plugins use the trace filter view
> > org.eclipse.tracecompass.tmf.ui.views.filter.FilterView to allow the
> > user to define filters to filter events in the trace editor view. This
> > worked fin in the Neon Eclipse release but is not working any more in
> > the Oxygen release.
> >
> > I can define a filter and save it so that it shows up in the filter
> > list when I right click in the trace editor view. However, when I
> > select that filter, the updated trace editor view always shows me an
> > empty view with no events.
> >
> > I have tried simple filters with only a single Aspect, where I have
> > tried using the Equals, Matches and Contains conditions as well as
> > ignoring case, and none of them show any matching events.
> >
> > The Aspect classes I use simply implement the ITmfEventAspect
> > interface where the resolve method returns a String object containing
> > the value of the requested field, where that value shows up correctly
> > in the trace editor view.
> >
> > Has something changed between the Neon and Oxygen SR1 releases that
> > affects how trace filters are supposed to work, and which I may not
> > have realized?
> >
> > Dave
> >
> >
> > _______________________________________________
> > tracecompass-dev mailing list
> > tracecompass-dev@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> >
>
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_tracecompass-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=yA1Giwd7Ls577uUKQ3fQWICGHopYggQ46OvlB30WK5M&m=W5ll3bCBlBLvS-pFP7OyQVd0AWn8M3jMiOrQZH_wKTw&s=x92EscW_6gkhI80T2WKASs8KuQnYido3l0aGy5TKrdQ&e=

>
> _______________________________________________
> tracecompass-dev mailing list
> tracecompass-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_tracecompass-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=yA1Giwd7Ls577uUKQ3fQWICGHopYggQ46OvlB30WK5M&m=W5ll3bCBlBLvS-pFP7OyQVd0AWn8M3jMiOrQZH_wKTw&s=x92EscW_6gkhI80T2WKASs8KuQnYido3l0aGy5TKrdQ&e=

>
>
>
>
>
>
> _______________________________________________
> tracecompass-dev mailing list
> tracecompass-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_tracecompass-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=yA1Giwd7Ls577uUKQ3fQWICGHopYggQ46OvlB30WK5M&m=NPHfZ0SaUQilUnpQOlnLghzpffU11jZvYDT4nRopGME&s=T6KUP30IVqKq4p1CtLk9AtABy0HGl9ipW0OSjDZjjvw&e=

_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_tracecompass-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=yA1Giwd7Ls577uUKQ3fQWICGHopYggQ46OvlB30WK5M&m=NPHfZ0SaUQilUnpQOlnLghzpffU11jZvYDT4nRopGME&s=T6KUP30IVqKq4p1CtLk9AtABy0HGl9ipW0OSjDZjjvw&e=





_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev

_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_tracecompass-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=yA1Giwd7Ls577uUKQ3fQWICGHopYggQ46OvlB30WK5M&m=82OvaeKYAzL-DqkKFRIBLvWg0JMYdMGM_P_vB0QGbS0&s=uWBdczbX0TA2X_xK9odf14ci9rXUmW1EZO7tqreghao&e=