Re: [theia-dev] We are going ahead! - Was: Re: Release of vscode built-i

[Marc Dumais <marc.dumais@xxxxxxxxxxxx>]

I have validated that CI still passes in the main repo (master branch), using vscode built-ins 1.77.0 that are now pulled, and it does.

Have a good weekend! 

Marc

---

From: theia-dev <theia-dev-bounces@xxxxxxxxxxx> on behalf of Marc Dumais via theia-dev <theia-dev@xxxxxxxxxxx>
Sent: Friday, May 26, 2023 3:45 PM
To: theia developer discussions <theia-dev@xxxxxxxxxxx>; theia developer discussions <theia-dev@xxxxxxxxxxx>; Thomas Mäder <t.s.maeder@xxxxxxxxx>
Cc: Marc Dumais <marc.dumais@xxxxxxxxxxxx>; Wayne Beaton <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx>
Subject: [theia-dev] We are going ahead! - Was: Re: Release of vscode built-ins 1.77.0 - wait for IP check tickets resolution?

 

Hi all,

I'm proceeding with the release of built-ins 1.77.0. Earlier today I investigated the pending 3PP IP check tickets and provided analysis on them. They were all approved. For the remaining ticket regarding the use of the vscode built-ins sources, I have investigated every file flagged as "restricted" by Scancode and found nothing suspicious. See details below [1] for this last item, if interested. 

Thank you, Thomas, for your good work on coordinating this upcoming community release, thanks also to all committers and contributors who took part in the new content : may this be the greatest community release yet!

Marc

[1]: 

# files that were flagged as restricted in 1.77.0 IP check ticket and time of last commit:

extensions/typescript-language-features/cgmanifest.json , Tue Sep 7 14:27:38 2021 -0700

extensions/diff/cgmanifest.json , Tue Dec 7 15:09:32 2021 +0100

extensions/groovy/cgmanifest.json , Mon Feb 4 16:35:48 2019 +0100

extensions/html/cgmanifest.json , Wed Feb 6 15:16:49 2019 +0100

extensions/ini/cgmanifest.json , Mon Feb 4 16:35:48 2019 +0100

extensions/lua/cgmanifest.json , Fri Dec 2 23:12:07 2022 +0800

extensions/make/cgmanifest.json , Tue Jan 10 11:50:28 2023 +0100

extensions/perl/cgmanifest.json , Tue Aug 10 16:57:21 2021 +0200

extensions/ruby/cgmanifest.json , Mon Mar 29 15:10:29 2021 +0200

extensions/vb/cgmanifest.json , Mon Feb 4 16:35:48 2019 +0100

extensions/cpp/cgmanifest.json , Fri Feb 24 17:22:41 2023 +0100

extensions/css/cgmanifest.json ,  Mon Jan 30 15:27:20 2023 +0100

extensions/_javascript_/cgmanifest.json , Tue Sep 15 19:13:49 2020 -0400

extensions/markdown-basics/cgmanifest.json , Fri Feb 24 17:22:41 2023 +0100

# Filter-down to files that changed between the last approved version (1.72.2)

# and this one (1.77.2)

# 1.72.2: Oct 12, 2022

# 1.77.0: Mar 30 2023

*** extensions/lua/cgmanifest.json , Fri Dec 2 23:12:07 2022 +0800

*** extensions/make/cgmanifest.json , Tue Jan 10 11:50:28 2023 +0100

*** extensions/cpp/cgmanifest.json , Fri Feb 24 17:22:41 2023 +0100

*** extensions/css/cgmanifest.json ,  Mon Jan 30 15:27:20 2023 +0100

*** extensions/markdown-basics/cgmanifest.json , Fri Feb 24 17:22:41 2023 +0100

# For each, look at what changed since our last approved release (1.72.2)

*** extensions/lua/cgmanifest.json , Fri Dec 2 23:12:07 2022 +0800

git log extensions/lua/cgmanifest.json

git diff 930fd0e469a43fd923cd732c178e3cc9e878b58d  e8753df2e88e8982c550a9318d0b8f473fa9cf14 extensions/lua/cgmanifest.json

diff --git a/extensions/lua/cgmanifest.json b/extensions/lua/cgmanifest.json

index c1b98909447..784ad5bbc19 100644

--- a/extensions/lua/cgmanifest.json

+++ b/extensions/lua/cgmanifest.json

@@ -6,7 +6,7 @@

                                "git": {

                                        "name": "sumneko/lua.tmbundle",

                                        "repositoryUrl": "https://github.com/sumneko/lua.tmbundle",

-                                       "commitHash": "57be7c5cf8fa173f5f39806822725e503932ab45"

+                                       "commitHash": "bc74f9230c3f07c0ecc1bc1727ad98d9e70aff5b"

                                }

                        },  

vscode.proposed.contribViewsRemote.d.ts

(File)

   

                        "licenseDetail": [

*** extensions/make/cgmanifest.json , Tue Jan 10 11:50:28 2023 +0100

git log extensions/make/cgmanifest.json

git diff 91db8ea85fee30ebb3c7a5e7939aa2a8d79811c5  473c57e261f50c74fcd8f7bb3d40b39ef09931c6 extensions/make/cgmanifest.json

diff --git a/extensions/make/cgmanifest.json b/extensions/make/cgmanifest.json

index 6548e081a2b..44cfa092993 100644

--- a/extensions/make/cgmanifest.json

+++ b/extensions/make/cgmanifest.json

@@ -6,7 +6,7 @@

                                "git": {

                                        "name": "fadeevab/make.tmbundle",

                                        "repositoryUrl": "https://github.com/fadeevab/make.tmbundle",

-                                       "commitHash": "1d4c0b541959995db098df751ffc129da39a294b"

+                                       "commitHash": "ef0c485afc66445a6cf184dc34f7744306304f1f"

                                }

                        },

                        "licenseDetail": [

*** extensions/latex/cgmanifest.json , Fri Feb 24 17:22:41 2023 +0100

git log extensions/latex/cgmanifest.json

git diff cf4acb805047ff9a47e83cf5237b74853dcce6ea fb2837b03f9455c2d8f90fef228a028c473f8775 extensions/latex/cgmanifest.json

index 1765e5f63c2..7d36599bab8 100644

--- a/extensions/latex/cgmanifest.json

+++ b/extensions/latex/cgmanifest.json

@@ -6,11 +6,11 @@

                                "git": {

                                        "name": "jlelong/vscode-latex-basics",

                                        "repositoryUrl": "https://github.com/jlelong/vscode-latex-basics",

-                                       "commitHash": "eed5b817b757aab3695af437409fcbfdd37bbc59"

+                                       "commitHash": "e02a22742b3e6e0ee088e9c11109950abd7441d0"

                                }

                        },

                        "license": "MIT",

-                       "version": "1.5.1",

+                       "version": "1.4.0",

                        "description": "The files in syntaxes/ were originally part of https://github.com/James-Yu/LaTeX-Workshop. They have been extracted in the hope that they can useful outside of the LaTeX-Workshop extension.",

                        "licenseDetail

index d914bf08dcb..a74605bb49b 1": [

                                "Copyright (c) vscode-latex-basics authors",

*** extensions/cpp/cgmanifest.json , Fri Feb 24 17:22:41 2023 +0100

git log extensions/cpp/cgmanifest.json

git diff cf4acb805047ff9a47e83cf5237b74853dcce6ea ceaf7a431bdad3d05c33c8d711a16d1be6f8db00 extensions/cpp/cgmanifest.json

index 2a52ca43b94..77eda2c94e3 100644

--- a/extensions/cpp/cgmanifest.json

+++ b/extensions/cpp/cgmanifest.json

@@ -6,11 +6,11 @@

                                "git": {

                                        "name": "jeff-hykin/better-cpp-syntax",

                                        "repositoryUrl": "https://github.com/jeff-hykin/better-cpp-syntax",

-                                       "commitHash": "7aef15d9203f0dfeaf075f0673ab3ab382dfb0b1"

+                                       "commitHash": "1866de22c09781cbceacc2c98063f7bf77b1ca62"

                                }

                        },

                        "license": "MIT",

-                       "version": "1.17.4",

+                       "version": "1.16.1",

                        "description": "The original JSON grammars were derived from https://github.com/atom/language-c which was originally converted from the C TextMate bundle https://github.com/textmate/c.tmbundle."

                },

                {

*** extensions/css/cgmanifest.json ,  Mon Jan 30 15:27:20 2023 +0100

git log extensions/css/cgmanifest.json

git diff 166b8e2d907eca16ce55347aa5b0befa840c0e6a 9bcc5774781d8e04e5e96f04e517136454061c2f  extensions/css/cgmanifest.json

diff --git a/extensions/css/cgmanifest.json b/extensions/css/cgmanifest.json

index 871e828facb..6e4b143b4a8 100644

--- a/extensions/css/cgmanifest.json

+++ b/extensions/css/cgmanifest.json

@@ -6,7 +6,7 @@

                                "git": {

                                        "name": "microsoft/vscode-css",

                                        "repositoryUrl": "https://github.com/microsoft/vscode-css",

-                                       "commitHash": "4a6dc90f332bfa72c88192513435a64013d9aad4"

+                                       "commitHash": "f9433d2d5f65d2c97ce59eba7c15d3b95960b128"

                                }

                        },

                        "licenseDetail": [

@@ -46,8 +46,8 @@

                        ],

                        "license": "MIT License",

                        "description": "The file syntaxes/css.tmLanguage.json was derived from https://github.com/atom/language-css which was originally converted from the TextMate bundle https://github.com/textmate/css.tmbundle.",

-                       "version": "0.45.1"

+                       "version": "0.0.0"

                }

        ],

        "version": 1

-}

\ No newline at end of file

+}

*** extensions/markdown-basics/cgmanifest.json , Fri Feb 24 17:22:41 2023 +0100

git log extensions/markdown-basics/cgmanifest.json

git diff cf4acb805047ff9a47e83cf5237b74853dcce6ea 166b8e2d907eca16ce55347aa5b0befa840c0e6a extensions/markdown-basics/cgmanifest.json

index d914bf08dcb..a74605bb49b 100644

--- a/extensions/markdown-basics/cgmanifest.json

+++ b/extensions/markdown-basics/cgmanifest.json

@@ -33,7 +33,7 @@

                                "git": {

                                        "name": "microsoft/vscode-markdown-tm-grammar",

                                        "repositoryUrl": "https://github.com/microsoft/vscode-markdown-tm-grammar",

-                                       "commitHash": "ca2caf2157d0674be3d641f71499b84d514e4e5e"

+                                       "commitHash": "443261e8f75b2eaa8b36a2613fe7c4354208260a"

                                }

                        },

                        "license": "MIT",

---

From: Marc Dumais <marc.dumais@xxxxxxxxxxxx>
Sent: Thursday, May 25, 2023 9:11 AM
To: theia developer discussions <theia-dev@xxxxxxxxxxx>; theia developer discussions <theia-dev@xxxxxxxxxxx>; Thomas Mäder <t.s.maeder@xxxxxxxxx>
Cc: Wayne Beaton <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [theia-dev] Release of vscode built-ins 1.77.0 - wait for IP check tickets resolution?

 

Hi Thomas, see below.

---

From: Thomas Mäder <t.s.maeder@xxxxxxxxx>
Sent: Thursday, May 25, 2023 8:43 AM
To: theia developer discussions <theia-dev@xxxxxxxxxxx>; theia-dev@xxxxxxxxxxx <theia-dev@xxxxxxxxxxx>
Cc: Marc Dumais <marc.dumais@xxxxxxxxxxxx>; Wayne Beaton <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [theia-dev] Release of vscode built-ins 1.77.0 - wait for IP check tickets resolution?

 

------ Original Message ------

From "Marc Dumais via theia-dev" <theia-dev@xxxxxxxxxxx>

• To me it looks like the cgmanifest.json files are describing licensing for components. Shouldn't they be excluded from the check, since they are essentially metadata, not code?
  

Possibly. The Foundation encourages us to remove "test/build" content that's not published, to make the check less likely to report false positives, on files that are not relevant. If we discuss it with the IP team and they agree, we could try this suggestion and remove these files from the source archive we provide. Alternatively, the automated license check made using scancode could be made smarter, detecting only changes "since last approved" in these files, or such. This way, we would not stumble on the same entries each time we open such a ticket but could still catch new such entries that might be interesting. 

In consequence, I propose we go ahead with releasing the vscode built-ins 1.77.0 and start using them. What do you think? Objections? 

• Can we do that under the Eclipse Foundation rules? What happens if something _does_ turn up? Do we "unpublish" the extensions? 
  

I think/hope so. Using logic and the tools at our disposal, like the scancode results, we can tell that this looks unlikely to happen, but if it does, we correct the course ASAP. In many cases I think this would mean that the 3PP in question would be approved for our project as "works with" or through a board exception. If this can't happen, we'll need to see what can be done instead. 

• What happens if we publish the community release without having the 1.77.0 built-ins released?
  

Then applications based on the community release would pull the latest built-ins that we published; I think 1.70.2. These were not tested nearly as well as 1.77.0 and probably have extra flaws. Also, when we eventually publish 1.77.0, these applications would start "silently" pulling these instead, potentially changing some behaviors, e.g. requiring the applications to suddenly have to pin some built-ins to an earlier version to keep things working the same. 

/Thomas