Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [theia-dev] Release of vscode built-ins 1.77.0 - wait for IP check tickets resolution?




------ Original Message ------
From "Marc Dumais via theia-dev" <theia-dev@xxxxxxxxxxx>
To "theia-dev@xxxxxxxxxxx" <theia-dev@xxxxxxxxxxx>
Cc "Marc Dumais" <marc.dumais@xxxxxxxxxxxx>; "Wayne Beaton" <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx>
Date 25/05/2023 14:17:04
Subject [theia-dev] Release of vscode built-ins 1.77.0 - wait for IP check tickets resolution?

Hi Theia developers,

Good news everyone!  We have completed the tests [1] for the vscode built-ins 1.77.0 and can technically publish them at will.

One matter remains: the ongoing IP check tickets. First - Mea culpa - I just registered said tickets yesterday. Most tickets were opened by dash-licenses, for 3PPs used in the vscode built-ins version 1.77.0. They have been detected by dash-licenses​ and an IP check ticket opened for each that were flagged by as requiring more attention​ [2]. I have confidence that these tickets will be approved in time, considering that these built-ins and 3PP are in wide use in vscode, vscodium and other derivatives.  This makes me confident that, in the unlikely case that a bad "IP surprise" lurks, the whole eco-system will be in the same boat.

There is also the overall IP check ticket for the vscode sources, that we use to build the built-ins [3]. Normally, we like to have all related IP tickets approved before a release. Lately, the turn-around time for tickets such as [3] is several weeks. Looking at that ticket's scancode results,  we can see that it was flagged for the EF IP Team involvement, based on scancode​ finding potentially license-related string matches in various "cgmanifest.json" files. Exactly the same suspicious files were flagged for the previous version of the built-ins we made: 1.72.2 [4]. 
To me it looks like the cgmanifest.json files are describing licensing for components. Shouldn't they be excluded from the check, since they are essentially metadata, not code?



All in all, I think the risk of going forward with releasing the built-ins 1.77.0 is low, and never has a set of vscode built-ins require so much effort to produce and validate (including related Theia platform work). I think it would be a shame to deprive Theia users, consumers of this monthly release or of the new community release, of this shiny new set of extensions, custom-made to go along with the newly added support for vscode extensions API 1.77.0. 

In consequence, I propose we go ahead with releasing the vscode built-ins 1.77.0 and start using them. What do you think? Objections? 
Can we do that under the Eclipse Foundation rules? What happens if something _does_ turn up? Do we "unpublish" the extensions? 

What happens if we publish the community release without having the 1.77.0 built-ins released?

/Thomas

Back to the top