Hi Joel,
Eclipse bylaws do not allow me to handle any code over e-mail.
OK. Thanks for the follow up.
To contribute to an Eclipse project, you need to create Eclipse account an do a bit of paperwork.
Eclipse requires contributors to agree to this Eclipse Contributor Agreement ("ECA"):
https://www.eclipse.org/legal/ECA.php
Done.
I should have remembered this since I have done contributor agreements with
other organizations before. Sorry.
Then, you can submit contributions by
either creating a bug report at https://bugs.eclipse.org/bugs/
or by submitting patches to Eclipse code review system https://wiki.eclipse.org/Gerrit
Which do you prefer?
--joel
Thanks,
Eugene
-----Original Message-----
From: tcf-dev-bounces@xxxxxxxxxxx <tcf-dev-bounces@xxxxxxxxxxx> On Behalf Of Joel Sherrill
Sent: Monday, November 2, 2020 2:55 PM
To: tcf-dev@xxxxxxxxxxx
Subject: [tcf-dev] [PATCH 0/2] Address warnings in TCF Agent
CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.
Hi,
I hope this is the right way to submit minor patches. If not, please educate me.
Compiling for GCC 7.5 targetting arm-rtems, there were a couple of warnings in the general agent source.
+ asyncreq.c has a potential buffer overflow where the return value from
snprintf() is not checked. Looking at the two values concatenated with a
/ between them, it seemed safer to check the return value than attempt to
make the destination buffer larger.
+ compression.c has a method declaration which is missing the word void
between the (). GCC says this is not proper.
Thanks.
--joel
Joel Sherrill (2):
asyncreq.c: Check return value from snprintf() for buffer overflow
compression.c: Fix gcc not a prototype warning
agent/tcf/framework/asyncreq.c | 4 +++-
agent/tcf/framework/compression.c | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
--
1.8.3.1
_______________________________________________
tcf-dev mailing list
tcf-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/tcf-dev
_______________________________________________
tcf-dev mailing list
tcf-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/tcf-dev
