Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tcf-dev] [PATCH 0/2] Address warnings in TCF Agent
  • From: Eugene Tarassov <eugenet@xxxxxxxxxx>
  • Date: Tue, 3 Nov 2020 00:27:27 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e2a6uOjuu8qHGVnKEguDMiefzqEG+LOkeaysyggvdxM=; b=GnonsQHtKFQRB1PeKwdYZD4cXmteUMwkh3ReQL+/3gsWTdI5Nlei++QyQbQc+wk0EYbJYUl48qEtOnyhIYHheVqTTznF36p3KhCD8bggwmr7bcZSz8RwkIpvDOJfsoR+9AVm9CrG+wyXSJWWV/51rWHUukW9F+DZ/0RDr2xyFIHgCJsa8dtjQC+hnZGjPIF7+P5wFfK0dFeo8JSWkS/fesHvkpmzX0CCuLtHMVPZlKigOx9jf/FobmzYfS0533l/tbJFH/5lbXbfQrXxg+D97Eb2R+0erGo1FQhRDWletqlcd2TYVjkrDmzrJrpriVoLVYkWYD3+GOJJj927V+Ataw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bEPFecquQ73tF9zYut+yxTQkwxknVHfgfQZ13NTKTWa9si5Sj0hmmhbQjtI+3ZLO6pKRYL6BsmmhzC/6ULYl7KIiGvkWgUk++oESeh50A7sMtr3dtybcMi37XHIS7EJKJ87zxT9nECWhupfqKLpuRXY/U6MhYaC2ulTyNt/xMTLSxSk/B7zwy1kH/o1W2VPUs1HxJAaws36WmIli/r1Z0ae3EsE3k3SZdacD6N8jholRAcl2xI7ZDa/sR23ba3hHwh2B30HtIIUfVN/CAz0ZWXFyhf3RBZ2cZ+HIF/mdC29IWwe1Z8c1D+aJLZa+Y0Q1X3i/m8MdNQkDJvT1cjEgmw==
  • Delivered-to: tcf-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/tcf-dev>
  • List-help: <mailto:tcf-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/tcf-dev>, <mailto:tcf-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/tcf-dev>, <mailto:tcf-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHWsXIpIeWm2aCTkUefFllRH1URS6m1hsWg
  • Thread-topic: [tcf-dev] [PATCH 0/2] Address warnings in TCF Agent
Hi Joel,

Eclipse bylaws do not allow me to handle any code over e-mail.

To contribute to an Eclipse project, you need to create Eclipse account an do a bit of paperwork.
Eclipse requires contributors to agree to this Eclipse Contributor Agreement ("ECA"):
https://www.eclipse.org/legal/ECA.php

Then, you can submit contributions by
either creating a bug report at https://bugs.eclipse.org/bugs/ 
or by submitting patches to Eclipse code review system https://wiki.eclipse.org/Gerrit

Thanks,
Eugene


-----Original Message-----
From: tcf-dev-bounces@xxxxxxxxxxx <tcf-dev-bounces@xxxxxxxxxxx> On Behalf Of Joel Sherrill
Sent: Monday, November 2, 2020 2:55 PM
To: tcf-dev@xxxxxxxxxxx
Subject: [tcf-dev] [PATCH 0/2] Address warnings in TCF Agent

CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.


Hi,

I hope this is the right way to submit minor patches. If not, please educate me.

Compiling for GCC 7.5 targetting arm-rtems, there were a couple of warnings in the general agent source.

+ asyncreq.c has a potential buffer overflow where the return value from
  snprintf() is not checked. Looking at the two values concatenated with a
  / between them, it seemed safer to check the return value than attempt to
  make the destination buffer larger.

+ compression.c has a method declaration which is missing the word void
  between the (). GCC says this is not proper.

Thanks.

--joel

Joel Sherrill (2):
  asyncreq.c: Check return value from snprintf() for buffer overflow
  compression.c: Fix gcc not a prototype warning

 agent/tcf/framework/asyncreq.c    | 4 +++-
 agent/tcf/framework/compression.c | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

--
1.8.3.1

_______________________________________________
tcf-dev mailing list
tcf-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/tcf-dev

Back to the top