Re: [stp-dev] Look and feel proposal for integration of XEF and WTP-base

[Andrei Shakirin <andrei.shakirin@xxxxxxxxx>]

Hi David,

1) org.eclipse.stp.policy.common plugin 
   Perfect, we will add and manage our common stuff there.

2) IPolicyDetailEditorInput. 
   Hmm ... I prefer to have the interface, not implementation class as basic agreement between editors.
   The both editors could be developed and used independently (and even integrated with another components in the future). I think it is quite important to provide clear interface between them and avoid dependences on implementation details like XMLProviderEditorInput, IXMLProvider, InputStreamHelper, etc.
   So we will depends only on interfaces and will stay open for another alternative implementations on both sides.
   What do you think?

Regards,
Andrei.

----- Original Message -----
From: "David Bosschaert" <davidb@xxxxxxxx>
To: "STP Dev list" <stp-dev@xxxxxxxxxxx>
Sent: Mittwoch, 16. Januar 2008 12.30 Uhr (GMT+0100) Europe/Berlin
Subject: Re: [stp-dev] Look and feel proposal for integration of XEF and	WTP-based policy editors

Hi Andrei,

I have added the org.eclipse.stp.policy.common plugin and put 
ISchemaProvider and ISchemaProviderExt in there.

On the IPolicyDetailEditorInput interface, I am slowly starting to think 
that we don't need this interface at all! You already said that you 
don't think the setters are needed and I don't really see why the 
getters are needed on it. Maybe we don't need it at all?
There would still be an implementation object PolicyDetailEditorInput 
implements IEditorInput which is used to pass information to the editor 
when it is started up, but I don't think an additional interface around 
it is needed.

See testTitleSetting() in 
http://dev.eclipse.org/svnroot/stp/trunk/org.eclipse.stp.policy/org.eclipse.stp.xef.test/src/org/eclipse/stp/ui/xef/policy/editor/PolicyDetailEditorTest.java 
for an example of how it would be used in the current implementation...

If you agree, that would simply leave the IPolicyDetailCallback class to 
be moved to the new org.eclipse.stp.policy.common plugin.

Cheers,

David

Andrei Shakirin wrote:
> Hi David,
>
> Absolutely agree! 
> I also would like to avoid direct dependencies between WTP and XEF editors.
> Just another name suggestion: "org.eclipse.stp.policy.common", because this stuff relates not only to XEF editor, but to STP policy framework as whole.
>
> Our detail editor interfaces and schema provider classes could be located in different packages of this plugin module.
>
> Regards,
> Andrei.
>
> ----- Original Message -----
> From: "David Bosschaert" <davidb@xxxxxxxx>
> To: "STP Dev list" <stp-dev@xxxxxxxxxxx>
> Sent: Dienstag, 15. Januar 2008 17.44 Uhr (GMT+0100) Europe/Berlin
> Subject: Re: [stp-dev] Look and feel proposal for integration of XEF and	WTP-based policy editors
>
> Hi Andrei,
>   
>> 2) I put ISchemaProvider interface also in the same package now.
>>    For the future I suggest to create separate plugin module containing schemas provider and policy repository stuff (ISchemaProvider, ISchemaProviderExt, URLSchemaProvider, etc). It helps to avoid circular dependencies between editors and allows to use the stuff from other modules (not only our editors).
>>   
>>     
> This makes sense to me. Esp since there are people who use the XEF 
> editor on its own already and I don't think they should be forced to 
> depend on the WTP policy editor plugins if they don't use that piece.
> I would be happy to create an interfaces-only plugin for the ones used 
> by the XEF editor. It could be called
>   org.eclipse.stp.xef.common
> This would allow to have the dependencies only go one way. Would that 
> work for you?
>
> Cheers,
>
> David
>
> ----------------------------
> IONA Technologies PLC (registered in Ireland)
> Registered Number: 171387
> Registered Address: The IONA Building, Shelbourne Road, Dublin 4, Ireland
>
> _______________________________________________
> stp-dev mailing list
> stp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/stp-dev
>
>   

----------------------------
IONA Technologies PLC (registered in Ireland)
Registered Number: 171387
Registered Address: The IONA Building, Shelbourne Road, Dublin 4, Ireland