Re: [stp-dev] Look and feel proposal for integration of XEF and WTP-base

[Andrei Shakirin <andrei.shakirin@xxxxxxxxx>]

Hi David,

I have checked-in the interfaces into module org.eclipse.stp.policy.wtp.editor, package org.eclipse.stp.policy.wtp.extensions.
Two notes:
1) IPolicyDetailEditorInput interface contains only getXXX methods to access the input arguments. Setters methods will be details of implementation class (I think it makes sense to put absolutely mandatory arguments as name, stream, callback into constructor and manage other arguments like project, provider, properties via setters).

2) I put ISchemaProvider interface also in the same package now.
   For the future I suggest to create separate plugin module containing schemas provider and policy repository stuff (ISchemaProvider, ISchemaProviderExt, URLSchemaProvider, etc). It helps to avoid circular dependencies between editors and allows to use the stuff from other modules (not only our editors).

Regards,
Andrei.

----- Original Message -----
From: "David Bosschaert" <davidb@xxxxxxxx>
To: "STP Dev list" <stp-dev@xxxxxxxxxxx>
Sent: Dienstag, 15. Januar 2008 16.10 Uhr (GMT+0100) Europe/Berlin
Subject: Re: [stp-dev] Look and feel proposal for integration of XEF and WTP-based policy editors

FYI - I have started making the changes to the XEF editor to support the 
proposed interfaces. For the moment the interfaces are located at
http://dev.eclipse.org/svnroot/stp/trunk/org.eclipse.stp.policy/org.eclipse.stp.xef/src/org/eclipse/stp/ui/xef/temp/
I will switch over to depend on org.eclipse.stp.policy.wtp.XXX as soon 
as they become available there. Andrei, could you let us know when this 
is the case?

Cheers,

David

David Bosschaert wrote:
> Hi Andrei,
>
> Andrei Shakirin wrote:
>> Hi David,
>>
>> 1) Ok, let do it with setters. Only the thing what I would like to 
>> review in the future: to distinguish assertion-scope input arguments 
>> (name, stream, callback) from policy-scope arguments (project, schema 
>> provider).
>> But let start with simple setters variant.
>>   
> Great, thanks.
>> 2) > BTW, note that I removed the getXXX methods from 
>> IPolicyDetailEditorInput ...
>>    I do not really understand it. Do you mean getName(), 
>> getCallback(), getProject(), getSchemaProvider() methods?
>>    If you remove these methods, how XEF Editor will get assertion 
>> name, input stream, schema provider prepared by WTP-Editor?
>>   
> Well I think an EditorInput implementation is typically an object 
> understood by the actual editor, we need an interface around it in 
> order not to be exposed to the actual internals of the editor to 
> clients. However, the editor will have it's own way to actually 
> interact with the EditorInput implementation object, IMHO.
> For instance, the XEF editor really provides IPolicyDetailEditorInput 
> as a facade to another (already existing) EditorInput 
> (XMLProviderEditorInput) which the XEF editor understands. Therefore 
> it doesn't need these getters.
> However, if you think they are important enough to keep, I would be 
> happy to keep them in...
>> 3) Location of IPolicyDetailEditorInput and IPolicyDetailCallback 
>> interfaces.
>>    I prefer to put them into WTP-based editor, do you agree with it?
>>   
> Yes, I agree.
>> 4) Have you already looked dev-list threads:
>>    - Storing and discovering XML Schemas for ws-policy assertions in 
>> Policy Editor;
>>    - Integration of Service Creation with Policy Editor planned for 
>> Ganymede release?
>>    What is your opinion?
>>   
> I will reply to those mails asap.
>
> Thanks again,
>
> David
>
> ----------------------------
> IONA Technologies PLC (registered in Ireland)
> Registered Number: 171387
> Registered Address: The IONA Building, Shelbourne Road, Dublin 4, Ireland
> ------------------------------------------------------------------------
>
> _______________________________________________
> stp-dev mailing list
> stp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/stp-dev
>   

----------------------------
IONA Technologies PLC (registered in Ireland)
Registered Number: 171387
Registered Address: The IONA Building, Shelbourne Road, Dublin 4, Ireland