[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [stellation-res] Checked in firebird changes
|
On Mon, 2002-09-02 at 15:43, Mark C. Chu-Carroll wrote:
>
>
> The changes are checked in.
Hi,
You forgot to check FirebirdDatabase.java in.
I cleaned again my repository and performed a full check out from CVS
and that file is missing.
>
> One question about it... Why did you override the createTable method
> in FirebirdDatabase?
I had problems when I tried to create the repository the first time.
I overrode the method because your code didn't include the NOT NULL
constraint and the foreign key name was wrong. I didn't delete the code
to test the changes you checked in later.
> All the override does is point it at the old table
> rendering code in the table class, which I never deleted. If you leave
> it with the inherited implementation, it will get updated when the
> BasicDatabase version is modified; I don't guarantee that the debug code
> in Table will get exactly the same updates as the real, active code.
>
> Instead of using the patches you included, I went through the code
> myself, to try to make sure nothing got missed. I only found one
> place where the NULL was a problem, and fixed it.
I will try the new code with my version of FirebirdDatabase.java and
will shout again if there are problems.
Rodolfo
--
MAXPROGRAMS
IBM Business Partner
Microsoft MSDN Business Connection Partner
rmraya@xxxxxxxxxxxxxxx
http://www.maxprograms.com
