[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[stellation-res] Checked in firebird changes
|
On Mon, 2002-09-02 at 18:29, Rodolfo M. Raya wrote:
> Hi,
>
> Here is another version of the Firebird access point with the copyright
> notice included.
The changes are checked in.
One question about it... Why did you override the createTable method
in FirebirdDatabase? All the override does is point it at the old table
rendering code in the table class, which I never deleted. If you leave
it with the inherited implementation, it will get updated when the
BasicDatabase version is modified; I don't guarantee that the debug code
in Table will get exactly the same updates as the real, active code.
Instead of using the patches you included, I went through the code
myself, to try to make sure nothing got missed. I only found one
place where the NULL was a problem, and fixed it.
-Mark
--
Mark Craig Chu-Carroll, IBM T.J. Watson Research Center
*** The Stellation project: Advanced SCM for Collaboration
*** http://www.eclipse.org/stellation
*** Work Email: mcc@xxxxxxxxxxxxxx ------- Personal Email:
markcc@xxxxxxxxxxx
