[stellation-res] Bugs to fix

["Rodolfo M. Raya" <rmraya@xxxxxxxxxxxxxxx>]

Hi all,

I just filed Bug 23070 because a problem with SQL reserved words used as field names blocked my work with the Firebird/InterBase port.

There are more  bugs that can be corrected without affecting the rest of the code.

In org.eclipse.stellation.repos.database.Table.java :

1) The method renderField(Field f) should be changed to:

    public String renderField(Field f) {
        if (f.isNullable()) {
            return f.getName() + " " + f.getType();
        } else {
            return f.getName() + " " + f.getType() + " NOT NULL ";
        }
    }


2) The first line of renderForeignKey(ForeignKey fk) should be changed to:

    public String renderForeignKey(ForeignKey fk) {
        String result = "CONSTRAINT " + fk.getConstraintName() + " FOREIGN KEY (";

 
In org.eclipse.stellation.repos.database.AbstractDBAccessPoint.java :

Method createRepository(String reposTag, Document configDoc) needs to rollback transactions on failures. I had to clean the database by hand after each failure in the middle of the process. Commit transaction is also missing. 


I have a working draft of Firebird access Point. Once bug 23070 is fixed i will post it for revision.

Nice wekend to all,

Rodolfo

-- 

 MAXPROGRAMS
 IBM Business Partner
 Microsoft MSDN Business Connection Partner
 rmraya@xxxxxxxxxxxxxxx
 http://www.maxprograms.com