Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[stellation-res] SvcConnectTest: assertion of 'true' and 'true\n'!

Hello Florin,

I have been able to launch your SvcConnectTest in combination with my
Oracle backend, but I think I found a little mistake. First of all,
does this test pass in your setup?

In the class org.eclipse.stellation.workspace.Test, I see the following
code:

if (options().get("verbose","").equals("true")) {
     System.out.println(answer ? "true" : "false");
}

This writes not only the word 'true', but also a newline character.
Later on in IORedirector, you read all the lines outputted by SVC and
compare that to the expected results. In there, an assertEquals happens
with the actual 'true\n' and the expected 'true'. With the newline in
the actual message, this test fails on me, while SVC has actually been
able to connect. I think you either have to strip the newline character
from the actual message, or add it to the expected message.

BTW, tnx for your work on the unit tests. They are very valuable when
developping the Oracle backend.

Cheers,

Ringo

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com


Back to the top