Re: [spatial4j-dev] pull requests?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

Re: [spatial4j-dev] pull requests?

From: "david.w.smiley@xxxxxxxxx" <david.w.smiley@xxxxxxxxx>
Date: Thu, 26 Mar 2015 23:38:34 -0400
Delivered-to: spatial4j-dev@xxxxxxxxxxxxxxxx
List-archive: <https://www.locationtech.org/mailman/private/spatial4j-dev>
List-help: <mailto:spatial4j-dev-request@locationtech.org?subject=help>
List-subscribe: <https://www.locationtech.org/mailman/listinfo/spatial4j-dev>, <mailto:spatial4j-dev-request@locationtech.org?subject=subscribe>
List-unsubscribe: <https://www.locationtech.org/mailman/options/spatial4j-dev>, <mailto:spatial4j-dev-request@locationtech.org?subject=unsubscribe>

On Thu, Mar 26, 2015 at 3:14 AM, Ryan McKinley <ryantxu@xxxxxxxxx> wrote:

I somehow messed up the PR #93, it should really just be:
https://github.com/spatial4j/spatial4j/commit/c9ee504f0f7fa4ec4078d9b7f8b413553f046662

GitHub is having issues related to a DDoS so I’ll comment here:

Overall this looks good. One thing:

* Why not make every (non-JTS) shape extend from BaseShape? You skipped over ShapeCollection in particular and I wonder why. At first I wondered why you didn’t have the JTS shapes extend BaseShape and I suppose it’s for convenience of declaring ‘ctx’ to be a JtsSpatialContext; is that the rationale?

~ David Smiley

Freelance Apache Lucene/Solr Search Consultant/Developer

http://www.linkedin.com/in/davidwsmiley

Prev by Date: Re: [spatial4j-dev] Writing shapes to WKT/GeoJSON
Next by Date: [spatial4j-dev] Code style
Previous by thread: [spatial4j-dev] Writing shapes to WKT/GeoJSON
Next by thread: [spatial4j-dev] Code style
Index(es):
- Date
- Thread

Breadcrumbs