| Re: [skalli-dev] Eclipse Code Conventions |
Hi all, I created https://bugs.eclipse.org/bugs/show_bug.cgi?id=345262 and attached a zipped git patch with the suggested JDT prefs and the reformatted code. The only changes compared to the previously checked in prefs are: - 4 blank indentation in *.java and *.xml files (instead of 2) to conform with Eclipse conventions - Never join already wrapped lines (from the Line Wrapping tab) I there are no concerns/objections raised I would like to commit that asap to not block further development. @Jochen hope that this results in not too many conflicts Regards Michael From: skalli-dev-bounces@xxxxxxxxxxx [mailto:skalli-dev-bounces@xxxxxxxxxxx] On Behalf Of Jochen Hiller +1, sounds reasonable. Any time plan for reformatting patch? I want to make a change for web-contextpaths other than "/", which requires changes in some files. It would make sense to have the reformatting patch yet in place. On Fri, May 6, 2011 at 2:52 PM, Wetzold, Robert <robert.wetzold@xxxxxxx> wrote: +1, this way also future contributers have it easier without the need to adapt to special settings. Should we go for a quick and big reformatting patch? From: skalli-dev-bounces@xxxxxxxxxxx [mailto:skalli-dev-bounces@xxxxxxxxxxx] On Behalf Of Simon Kaufmann Hi, when looking at the Eclipse Code Conventions [1], there are obviously some differences to the formatting of the Skalli code base (e.g. indentation). I don't want to start a religious war on that now, but I think it might not hurt to make any changes to the Skalli formatting rules as early as possible. What do you think? Cheers, Simon
|