Re: [sfcurve-dev] Addition of GeoWave Indexing Code To SFCurve

[Rob Emanuele <rdemanuele@xxxxxxxxx>]

Good point about the CQs.

According to this: https://github.com/locationtech/geowave/blob/master/core/index/pom.xml, the only new dependencies would be the findbugs (which is a bad dep according to eclipse) and json-lib (http://json-lib.sourceforge.net/, which seems based on json.org work - and we've had problems with that dependency before).

Problems with these dependencies would be problems with GeoWave, so good to catch these early.

Commenting about this on the pull request.

On Tue, Jun 13, 2017 at 11:46 AM, Jim Hughes <jnh5y@xxxxxxxx> wrote:

Hi James,

Thanks for the PR.  I commented on it to note a number of the details we'll have to work out before we can merge the work.

I think we will need to raise a number of Committer Questionnaires (CQs) for the PR.  Can you identify the dependencies that this work pulls in?

Cheers,

Jim

On 06/13/2017 11:34 AM, James McClain wrote:

Hello,

I made the following pull request: https://github.com/locationtech/sfcurve/pull/18 in which I have imported the GeoWave indexing code into the SFCurve project.

The is a direct importation with no changes, but the code does compile and can be published locally (sbt "project geowave-index" publishLocal) and tests do pass (sbt "project geowave-index" test).  Small-scale tests with GeoTrellis show that that the code appears to function.

I am writing to ask for comments and/or start a conversation about the pull request mentioned above.

Thank you,

James McClain

--

James McClain
Software Developer
Azavea  |  990 Spring Garden Street, 5th Floor, Philadelphia, PA 19123

_______________________________________________
sfcurve-dev mailing list
sfcurve-dev@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.locationtech.org/mailman/listinfo/sfcurve-dev

_______________________________________________
sfcurve-dev mailing list
sfcurve-dev@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.locationtech.org/mailman/listinfo/sfcurve-dev