Re: [servlet-dev] Diffs between EE4J_8 and master

[arjan tijms <arjan.tijms@xxxxxxxxx>]

Hi,

To me all those changes would be acceptable to be merged in the EE4J_8 branch. Very similar changes went into the the EE4J_8 branches of various other projects (JACC, JASPIC, ...) with a PMC member approval.

No objections either to pull the updates from EE4J_8 into master. They were done to make the release job work. This job is now indeed fully working as can be seen at jenkins.eclipse.org. Staging has been done as well, but (of course) no actual release yet. To re-stage the release on GitHub should be removed every time a re-stage is done. The script doesn't do that part automatically.

Kind regards,

Arjan

On Thu, Oct 18, 2018 at 12:14 PM Mark Thomas <markt@xxxxxxxxxx> wrote:

Hi,

I'm catching up with where things are and looking at the current diff
between EE4J_8 and master.

The ones I am most concerned about are the differences between the
pom.xml files. Any objection to a PR to pull the updates made only in
EE4J into master?

The remaining differences between the branches are - arguably - cosmetic
although my preference remains to fix as many as possible in the first
EE4J release.

They are:
- Javadoc warnings (missing parameters, wrong element order etc.)
- Format Javadoc as Javadoc not comment
- Redundant specification warnings <String> when <> works
- Unused imports
- Missing @Overrides
- Missing @Deprecated
- Avoid auto-(un)boxing
- Missing serialVersionUID

and they are in roughly priority order for me.

I am happy to produce individual PRs for each of the above. Which, if
any, would be acceptable?

Cheers,

Mark
_______________________________________________
servlet-dev mailing list
servlet-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/servlet-dev