|
Hello All,
This has received some minor reviews, but we could use some bigger ones overall. The Jakarta Platform team would like it if we could have a milestone on May 15th. This is about a month away. If those involved in the specification could give this a review that
would be helpful.
What this draft PR does lack is some additional TCK testing. This is something I can add, but I need to add the assertion JavaDoc's to the test I added.
One concern I have with the PR is using the @EntityParam annotation for the content parameter. There is no way to differentiate a method which uses CDI from a method that uses the old pattern of any non-annotated parameter is the entity/content.
I'm really not sure how we solve that without always requiring the @EntityParam
annotation on the entity/content parameter. This would require us change ALL TCK tests which use content to use the new annotation. It would also require a quite heafty migration path for users and libraries.
One option might be to simply not allow CDI injection for methods. This seems like the simplest option and then really the
@EntityParam annotation can just be removed.
I'm open to other thoughts and opinions 🙂
James R. Perkins
Software Developer
IBM
|