Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [rdf4j-dev] Github CI changes
  • From: "Bart Hanssens (BOSA)" <bart.hanssens@xxxxxxxxxxxx>
  • Date: Fri, 29 Nov 2019 10:12:25 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bosa.fgov.be; dmarc=pass action=none header.from=bosa.fgov.be; dkim=pass header.d=bosa.fgov.be; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eXz+sAi/qY0SsAA7gLR9KtE1WN8t3J70NeA/VTRutlE=; b=mKfIRlrQGDsFxvyTD7+Q81A2FBV0qci1vkoE1yS6FywDI659yhs0ftzNDsYv0UJnedtEezxDmQygwLnMjj4bsdg5nwVk9xtgKDzdYh4uf1YtWJmmIOO2VK+s6sK7VzEAj2TprX/VU3MQ/cQBd9EjLeVFIz0JbZGinWdu8bRlxTUFYBHHRzAqD8yr13eyy0WJ6mgxcCwivWmHvBMYLFsfMggTnn/Wp7ZIy6kqQj00IarQwpxsOumSNnKvyB0cfQtc9xP+P6lasSBWWeDgrWLUgxvk6FLAaxUwEynDZCQqFwK4nQEqDTnoQVFlsk6AcDSZtGPD40D6OMsc4rV1JUONvw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ejNPMNvpVFRelXwUtYNfHKSiw3pr2bL5wHsM1VlTecF7nHJ2t5ylxbs7gq3NhrjL0EbC6WVu3FgBZMIV+EM4zkqQuhTkhsMOAxkBAWm6NK0A229gCe/PqGj0tQshJELRxiiLWeIWnH2g3XEypqWJsxGEKqurQRIE9E5jYkZTI5g7ucKRPD/WyB15a5bIPptbruYqAe3KiaATi4AoGB1wpGzxEJLeBh/rtLRxu+XsO3uXHJPIAqorN6n0FQobsZ4NVO9VAeSci+8gJjFET9lcFjfRNg5a4LtveZK0iHBaVbw5o1BpaWyH8B96ZLbT2sklZgkNrhK8lAuSmScLDP2NIg==
  • Delivered-to: rdf4j-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/rdf4j-dev>
  • List-help: <mailto:rdf4j-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/rdf4j-dev>, <mailto:rdf4j-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/rdf4j-dev>, <mailto:rdf4j-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHVpji6LbR9hr2/m06jcOOgqlDQXKehK94AgAACn2CAAA4EAIAArPqAgAACxy8=
  • Thread-topic: [rdf4j-dev] Github CI changes

Indeed, looks like actions really are free for public repositories (minus some fair use limitations of course),
it's mentioned explicitly in this paragraph


"GitHub Actions usage is free for public repositories.
For private repositories, each GitHub account receives a certain amount of free minutes and storage, depending on the product used with the account"

Seems like a very nice offer 🙂


Best regards

Bart

From: rdf4j-dev-bounces@xxxxxxxxxxx <rdf4j-dev-bounces@xxxxxxxxxxx> on behalf of HÃ¥vard Ottestad <hmottestad@xxxxxxxxx>
Sent: Friday, November 29, 2019 10:54
To: rdf4j developer discussions <rdf4j-dev@xxxxxxxxxxx>
Subject: Re: [rdf4j-dev] Github CI changes
 
It’s a bit unclear from their website if open source projects are limited to 2000 minutes or not.

If you look at the pricing details here: https://github.com/features/actions

It says that public repos are free, and private ones are free for 2000 minutes. Doesn’t say unlimited minutes for the public repos though…so I reckon there are some usage limits there too, but might hopefully be higher than 2000 minutes.

HÃ¥vard

On 29 Nov 2019, at 00:35, Jeen Broekstra <jeen.broekstra@xxxxxxxxx> wrote:

Right, 2000 minutes per month. The current unit test flow takes about 30 minutes on average when successful, so that leaves us with roughly 66 runs a month. If we add full compliance testing for master and develop that will likely go down, but even if it drops to, say, 30 full runs a month, I think we should be good - it's one full run per day. We have more jobs started than that of course, but most fail early.

Let's see how we go.

Jeen

On Fri, Nov 29, 2019 at 9:50 AM Bart Hanssens (BOSA) <bart.hanssens@xxxxxxxxxxxx> wrote:

IIRC it is limited to a certain amount of free action minutes per month (https://github.com/pricing).

https://help.github.com/en/github/setting-up-and-managing-billing-and-payments-on-github/about-billing-for-github-actions

 

 

Best regards

 

Bart

 

From: rdf4j-dev-bounces@xxxxxxxxxxx <rdf4j-dev-bounces@xxxxxxxxxxx> On Behalf Of Jeen Broekstra
Sent: donderdag 28 november 2019 23:36
To: rdf4j developer discussions <rdf4j-dev@xxxxxxxxxxx>
Subject: Re: [rdf4j-dev] Github CI changes

 

Yeah can see it now. Loving it! Thanks Havard.

 

After I've taken care of the 3.0.3 release this weekend I'll work on putting in another action to do compliance testing of the master / develop branches. Once I'm happy with the setup, I'll start disabling the corresponding Jenkins jobs. Ideally, we end up with a situation where all our CI tasks are handled by Github, and Jenkins is only used for snapshot/release deployment.

 

I do have to admit I have a vague "too good to be true" feeling about the whole thing though. What's Github's commitment to providing these resources for free to open source projects?

 

Jeen

 

On Fri, Nov 29, 2019 at 9:11 AM "HÃ¥vard M. Ottestad" <hmottestad@xxxxxxxxx> wrote:

I made two PRs on GitHub. One that’s fails formatting and one that fails compilation. 

 

I feel it’s fairly easy to see what’s going on. And also, using steps and matrix builds cancels the other build and steps for that PR. 

 

HÃ¥vard



On 28 Nov 2019, at 03:28, Jeen Broekstra <jeen.broekstra@xxxxxxxxx> wrote:



Nice!

 

I am considering whether we should have these pre-steps as completely independent actions instead - that way you get more detailed feedback directly on the PR as it will tell you that the "formatting check" action failed, instead of "PR unit test" failing and then you have to dig in to see it failed on the formatting.  But I need to do a bit more reading up, there might be other ways to address that.

 

 

Jeen

 

On Thu, Nov 28, 2019 at 12:48 AM HÃ¥vard Ottestad <hmottestad@xxxxxxxxx> wrote:

Hi,

I’ve added a jdk 8 and jdk 11 matrix builds (it runs everything in both version) to the Github CI files (they call it Actions).

I’ve also added two pre-steps.

1. Run formatter:validate to check that the files were formatted correctly.
2. Run mvn install without tests to verify that the code compiles and builds.

This makes it easier to diagnose typical issues like forgetting to format or having a compile error.

Doesn’t increase the CI time. Also the matrix builds run in parallel :)

HÃ¥vard
_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/rdf4j-dev

_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/rdf4j-dev

_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/rdf4j-dev

_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/rdf4j-dev
_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/rdf4j-dev


Back to the top