Re: [rdf4j-dev] ElasticsearchStore

[Jeen Broekstra <jeen.broekstra@xxxxxxxxx>]

Hi Havard,

Sounds great! I look forward to seeing it in action and having a play. As for init after shutdown: I don't have any problems with disabling that option for a particular Sail implementation. The easiest way to do that is just to document that this particular Sail implementation can't do that, and then have the init() method throw a SailException if someone does try to re-initialize after a shutdown. That way, you don't break the API contract (though it's possible that there's a compliance test that doesn't cater for this scenario, in which case I'd disable that test for this specific Sail impl).

Cheers,

Jeen

On Sun, Nov 17, 2019 at 9:59 PM "Håvard M. Ottestad" <hmottestad@xxxxxxxxx> wrote:

Welcome back from your holiday Jeen!

I’ve been working on the ElasticsearchStore while you’ve been away, and it’s coming along nicely. Quite a few of the compliance tests are passing now and performance is fairly decent. Still a fair amount of more work needed.

Currently supported:
 - adding
 - querying
 - deleting
 - updating
 - rollback
 - read committed isolation
 - batch
 - connection reuse

One thing I’m not currently supporting is init after shutdown. I feel that shutdown is analogous to close, which means that it’s a final operation. Especially now that init is a lazy operation, it seems strange that it should be possible to shutdown a store and then still get a connection and update it. The reason why I’m brining it up is because getting a connection to Elasticsearch takes around 1 second so I need to have a store-wide connection that gets created on init and closed on shutdown. I also have a GC watcher that closes the connection if the store object gets garbage collected.

Any opinions on moving away from init after shutdown? Users can still create a new store object and initialise that instead.

Håvard
_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/rdf4j-dev