[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-ui-dev] macOS Dark



On Wed, Jul 11, 2018 at 12:28 PM, Becker, Matthias <ma.becker@xxxxxxx> wrote:
Dear platform devs,

In macOS 10.14 and later, users can choose to adopt a dark system-wide appearance instead of a light appearance (called Dark Mode See https://developer.apple.com/design/human-interface-guidelines/macos/visual-design/dark-mode/).

Has somebody already tested Eclipse on the macOS 10.14 beta? How does this OS dark mode interact with Eclipses Light and Dark Theme?

I'm not a Mac user but the following might help as we have gone through similar path on GTK.
There is a fragment http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.e4.ui.swt.gtk that checks if Eclipse Theme is dark and flips the GTK property so it auto adjusts most of the colors to match thus giving really good result on proper GTK themes (aka not Ubuntu as Ubuntu themes don't ship dark variants and the GTK property is a no-op on them).

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.e4.ui.swt.gtk/src/org/eclipse/e4/ui/swt/internal/gtk/DarkThemeProcessor.java#n40 is the interesting part from platform.ui POV but nothing hard to do.
Â

Regards,
Matthias

_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev



--
Alexander Kurtakov
Red Hat Eclipse Team