[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-ui-dev] PMC approval needed for patch https://git.eclipse.org/r/#/c/50300/ ?

Conrad, after writing my response, I noticed you used the wrong email
distribution list. Please register for the PMC mailing list and send
it to this list. See here:
https://accounts.eclipse.org/mailing-list/eclipse-pmc

On Mon, Mar 19, 2018 at 9:56 PM, Lars Vogel <lars.vogel@xxxxxxxxxxx> wrote:
>  +1 from my side (as I suggest to Conrad to ask the PMC for
> permission). I know Conrad and he has a very deep understanding of DB
> and I trust his judgment.
>
> Also, the API relevant change is minimal with only two (small) classes.
>
> On Mon, Mar 19, 2018 at 9:31 PM, Conrad Groth <info@xxxxxxxxxxxxxxx> wrote:
>> The patch https://git.eclipse.org/r/#/c/50300/ is nearly finished, but the
>> API tools want to have an @since tag for the public convert method in the
>> two public classes NumberToStringConverter and StringToNumberConverter.
>> Because both classes only have a private constructor there can be no
>> subclasses. And existing users are not affected by defining a more specific
>> return type, because this is binary-compatible. Is there a chance to get a
>> PMC approval for this pseudo-API-change?
>>
>>
>>
>> The current author of the above mentioned patch, Jens Lidestrom, did a good
>> job and it would be nice to have this in Photon.
>>
>>
>>
>> Best regards
>>
>> Conrad
>>
>>
>> _______________________________________________
>> platform-ui-dev mailing list
>> platform-ui-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe from
>> this list, visit
>> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>
>
>
> --
> Eclipse Platform project co-lead
> CEO vogella GmbH
>
> Haindaalwisch 17a, 22395 Hamburg
> Amtsgericht Hamburg: HRB 127058
> GeschÃftsfÃhrer: Lars Vogel, Jennifer Nerlich de Vogel
> USt-IdNr.: DE284122352
> Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com



-- 
Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
GeschÃftsfÃhrer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com