[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [platform-ui-dev] PMC approval needed for patch https://git.eclipse.org/r/#/c/50300/ ?
- From: Lars Vogel <lars.vogel@xxxxxxxxxxx>
- Date: Mon, 19 Mar 2018 21:56:21 +0100
- Delivered-to: firstname.lastname@example.org
+1 from my side (as I suggest to Conrad to ask the PMC for
permission). I know Conrad and he has a very deep understanding of DB
and I trust his judgment.
Also, the API relevant change is minimal with only two (small) classes.
On Mon, Mar 19, 2018 at 9:31 PM, Conrad Groth <info@xxxxxxxxxxxxxxx> wrote:
> The patch https://git.eclipse.org/r/#/c/50300/ is nearly finished, but the
> API tools want to have an @since tag for the public convert method in the
> two public classes NumberToStringConverter and StringToNumberConverter.
> Because both classes only have a private constructor there can be no
> subclasses. And existing users are not affected by defining a more specific
> return type, because this is binary-compatible. Is there a chance to get a
> PMC approval for this pseudo-API-change?
> The current author of the above mentioned patch, Jens Lidestrom, did a good
> job and it would be nice to have this in Photon.
> Best regards
> platform-ui-dev mailing list
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
Eclipse Platform project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
GeschÃftsfÃhrer: Lars Vogel, Jennifer Nerlich de Vogel
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com