Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [platform-ui-dev] Proposed name changes

Title: Message
Good idea. I like all the names except the Sdk ones. How about renaming StackPresentation to AbstractStackPresentation, BasicStackPresentation to just StackPresentation, PartTabFolderPresentation to ViewStackPresentation, and EditorPresentation to EditorStackPresentation.
-----Original Message-----
From: platform-ui-dev-admin@xxxxxxxxxxx [mailto:platform-ui-dev-admin@xxxxxxxxxxx] On Behalf Of Stefan Xenos
Sent: Thursday, May 06, 2004 8:18 PM
To: platform-ui-dev@xxxxxxxxxxx
Subject: [platform-ui-dev] Proposed name changes

I've been hearing a lot of questions about the purpose of various workbench internal classes. To help resolve some of this confusion, I would like to propose the following name changes (to non-API classes).

PartStack (remains unchanged)
PartTabFolder -> ViewStack
EditorWorkbook -> EditorStack

PartSashContainer (remains unchanged)
RootLayoutContainer -> ViewSashContainer
EditorArea -> EditorSashContainer

BasicStackPresentation -> SdkPartPresentation
PartTabFolderPresentation -> SdkViewPresentation
org.eclipse.ui.internal.presentations.EditorPresentation -> SdkEditorPresentation

org.eclipse.ui.internal.PerspectivePresentation -> PerspectiveHelper
org.eclipse.ui.internal.EditorPresentation -> EditorAreaHelper

This makes the names more consistent: The *Stack classes manage a set of tabs, the *SashContainers manage areas of Stacks separated by sashes, and the Sdk*Presentation classes are specific to the Eclipse 3.0 "new look". Similarly, the View* classes are specific to views, the Editor* classes are specific to editors, and the Part* classes are common to both editors and views.

PerspectivePresentation and org.eclipse.ui.internal.EditorPresentation should be renamed (to anything, really) since they are commonly mistaken as part of the new presentation API, and we should avoid creating classes called "presentation" outside of the presentation packages.

Please indicate if you think these name changes are worthwhile or have any other suggestions.

  - Stefan

Back to the top