[platform-ui-dev] Re: New Project Wizard

[Simon_Arsenault@xxxxxxx]

Sebastian,

Thanks for your contributions. I will look over them and apply them is
acceptable.

Note, it is best to communicate with the platform-ui-dev@xxxxxxxxxxx
mailing list.

See my comments below...

Thanks!
Simon :-)




                                                                                                                   
                      sdavids@xxxxxxx                                                                              
                                               To:      "Simon_Arsenault@xxxxxxx" <Simon_Arsenault@xxxxxxx>        
                      02/15/2002 11:21         cc:                                                                 
                      PM                       Subject: New Project Wizard                                         
                                                                                                                   
                                                                                                                   



Hi Simon,

thanks for pointing me into the right direction.

I've fixed bugs 9039 & 9955 (the patch is on both pages) -- I've also went
ahead and marked them "fixed" -- probably a little bit to eager (see 2.
below)


SA> Yes, please do not mark them as fixed until a commiter has reviewed the
patch and applied it. I will reopen these two until the patches reviewed.


@@@@

I have a couple of questions if you don't mind:

1. null vs. ""

Looking through the source code I've encountered "setMessage(null);" (and
similar calls); is there a reason for using "null"? -- The article "How to
Use
the Eclipse API" stated that one should try not use "null" in API calls. Is
it OK to change the respective calls to "setMessage("");"?


SA> You can't change this code because WizardPage.setMessage(String)
specifies null as a valid value. It's a way to indicate that the message
should be cleared.


2. ASSIGNED / FIXED

What if I find a bug and want to assign it to myself? What if I fix it?

Should I change the status and/or the resolution myself?


SA> I would suggest that you add a comment to the problem report you want
to work on. If you come up with a fix, add another comment and attach the
patch. Or if you decide to not work on it anymore, simply add another
comment. You should never change the resolution to fixed - a committer
needs to review the patch first and apply it if acceptable.


3. Code Formatter

What are the "official" settings for the Code Formatter? How do I get the
VAJ flush-left style?


SA> I do not know that the ui team has any special code formatter settings.
Most of the code is left align because it was imported from VAJ.


@@@@

I'd like to go ahead and work on the project wizard some more, OK?

SA> Sure...if you could let us know what your plans are (i.e what you are
trying to fix or improve). And again, thanks for helping out!


@@@@

Sebastian Davids

--
>>[ Sebastian Davids - Email: <sdavids@xxxxxx> ICQ: 2267
6231 ]<<
>>[ PGP-FP: 0DF6 5D15 6B32 683D 9CC7 287D 4744 D881 B284
04FE ]<<

GMX - Die Kommunikationsplattform im Internet.
http://www.gmx.net