Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-swt-dev] Bumping minimum version of GTK3 to 3.14in4.11
Hi folks,

It seems that this discussion may be partly moot anyway as 2018-12 and 2018-09 already require at least GTK 3.7.6, perhaps later? 

In July it was announced[1] that 3.0 was going to be the minimum version of GTK. But changes[2] in the code base before 2018-09 was released means that SWT does not work in (for example) GTK 3.6. The reason is that the change uses a method in GTK that had its internal name changed between GTK 3.7.4 and 3.7.6. The GTK_TYPE_TEXT_VIEW_ACCESSIBLE macro changed[3] the symbol used. So if you try and run Eclipse on an older GTK you get the following and a JVM failed to start error popup.

/home/tools/local/java/Linux64/jdk8u172-b11/bin/java: symbol lookup error: /home/hall/eclipse.2018.12/eclipse/configuration/org.eclipse.osgi/456/0/.cp/libswt-pi3-gtk-4922r31.so: undefined symbol: gtk_text_view_accessible_get_type

as older GTK versions the symbol was _gtk_text_view_accessible_get_type. (The GTK version for the above error is 3.6.2, I coincidentally came across it yesterday when doing a customer site visit and came across an old Fedora 18 machine.)

Just to be clear, I am not asking for support for such old GTKs, but rather for the documentation/N&N[4] to specify what the minimum GTK really is. 

As a related issue, the above type of failure means that the checks in Display.java (createDisplay) are also not working as intended because instead of a warning to System.out ("***WARNING: SWT requires GTK[...]") eclipse fails to load in OS.java's static initialization where it does the loadLibrary.

Would you like me to turn any of the above into bug reports?


Thanks,
Jonah





~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com


On Mon, 3 Dec 2018 at 18:39, Eric Williams <ericwill@xxxxxxxxxx> wrote:
I have opened a ticket for this:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=541862

Eric

On 11/30/18 2:56 AM, Sravan K Lakkimsetti wrote:
> +1 for taking middle ground
>
> Thanks and Regards,
>
> Sravan
>
> Sravan Kumar Lakkimsetti
>
> IBM India Pvt Ltd,
>
> Embassy Golf Links Business Park, D Block,
>
> Off Indiranagar-Kormangla Inner Ring Road,
>
> Bangalore - 560071, India
>
> Phone: 91-80-41776858
>
> *From:* Aleksandar Kurtakov <akurtako@xxxxxxxxxx>
> *Sent:* Friday, November 30, 2018 1:23 PM
> *To:* developers, Eclipse <platform-swt-dev@xxxxxxxxxxx>
> *Subject:* Re: [platform-swt-dev] Bumping minimum version of GTK3 to
> 3.14 in4.11
>
> On Fri, Nov 30, 2018 at 8:50 AM Sravan K Lakkimsetti
> <sravankumarl@xxxxxxxxxx <mailto:sravankumarl@xxxxxxxxxx>> wrote:
>
>     We use SLES 12 on our JIPPs. And GTK version available here is 3.10.9.
>
>     Now moving to 3.14 will make the gerrit jobs to fail for all
>     components(specifically UI tests). We will need to upgrade our
>     infrastructure to upgrade OS on all JIPPs. I don’t think that is a
>     good option considering we are trying to move to Cloudbees Jenkins
>     Enterprise(CJE). With CJE we will run on an OS configuration of our
>     choosing
>
>     I suggest a delay to 4.12 as I am expecting CJE migration to be
>     complete by that time.
>
> I think we should take the middle ground here - and bump the min Gtk
> version to Gtk 3.10. It would still be an improvement for maintenance
> and will make the next round smaller. Furthermore, CJE migration might
> need additional cycle (my previous experience with the SLES 11 -> 12
> migration) so we would better get what we can now.
>
>     Thanks and Regards,
>
>     Sravan
>
>     Sravan Kumar Lakkimsetti
>
>     IBM India Pvt Ltd,
>
>     Embassy Golf Links Business Park, D Block,
>
>     Off Indiranagar-Kormangla Inner Ring Road,
>
>     Bangalore - 560071, India
>
>     Phone: 91-80-41776858
>
>     *From:* Aleksandar Kurtakov <akurtako@xxxxxxxxxx
>     <mailto:akurtako@xxxxxxxxxx>>
>     *Sent:* Friday, November 30, 2018 12:19 AM
>     *To:* developers, Eclipse <platform-swt-dev@xxxxxxxxxxx
>     <mailto:platform-swt-dev@xxxxxxxxxxx>>
>     *Subject:* Re: [platform-swt-dev] Bumping minimum version of GTK3 to
>     3.14 in 4.11
>
>     On Thu, Nov 29, 2018 at 8:36 PM Leo Ufimtsev <Leonidas@xxxxxxxxxx
>     <mailto:Leonidas@xxxxxxxxxx>> wrote:
>
>         +1. Multiple dnd logic is confusing.
>
>     +1.
>
>     Sounds like we have an agreement from the people that touched the
>     code in the last few years :) .
>
>         On Thu, Nov 29, 2018 at 12:39 PM Andrey Loskutov
>         <loskutov@xxxxxx <mailto:loskutov@xxxxxx>> wrote:
>
>             +1 from me.
>             No doubts, with more resources this would be may be
>             different, but for now we have no other alternative.
>             Maintaining this spaghetti code is a Nightmare.
>
>             Am 29. November 2018 18:03:20 MEZ schrieb Eric Williams
>             <ericwill@xxxxxxxxxx <mailto:ericwill@xxxxxxxxxx>>:
>              >Hello,
>              >
>              >For the 4.11 release, I believe SWT will strongly benefit
>             from moving
>              >to
>              >a minimum version of GTK3.14. Here are some specific details:
>              >
>              >-CSS for backgrounds and foregrounds is 3.14+, no more
>             GtkStyleContext
>              >background/foreground machinery
>              >
>              >-no need to support pre-3.10 drawing model changes
>              >
>              >-gtk-gradient CSS is gone in GTK4, we only use it for
>             Combo on GTK3.12
>              >and below
>              >
>              >-removal of non-Cairo setRegion() drawing as this is 3.8
>             and below
>              >
>              >-removal of pre-GTK3.10 DnD logic
>              >
>              >-removal of miscellaneous functions such as: GtkWidget
>             opacity,
>              >GtkScrolledWindow add_with_viewport, etc.
>              >
>              >-removal of several pre-GTK3.14 Table/Tree drawing hacks
>              >
>              >-greatly allows for simplification of Cairo drawing in GC,
>             as many of
>              >these operations are guarded with GTK3.14+ calls
>              >
>              >-allows SWT to rely solely on GTK CSS theme parsing, no more
>              >GtkStyleContext lookups to get system colours
>              >
>              >
>              >In summary, these changes would really simplify the
>             codebase as almost
>              >all the items mentioned above are gone in GTK4. With the
>             introduction
>              >of
>              >GTK4 guards it would be really beneficial if we could start to
>              >eliminate
>              >the GTK3 specific version guards. Furthermore, it is very
>             hard to find
>              >a
>              >modern (supported) Linux distribution that ships with
>             anything less
>              >than
>              >GTK3.14 anymore, and the disconnect between the 3.14- and
>             3.24
>              >methodologies is quite large.
>              >
>              >If anyone has any concerns, please raise them.
>              >
>              >Thanks,
>
>             --
>             Kind regards,
>             Andrey Loskutov
>
>             http://google.com/+AndreyLoskutov
>             _______________________________________________
>             platform-swt-dev mailing list
>             platform-swt-dev@xxxxxxxxxxx
>             <mailto:platform-swt-dev@xxxxxxxxxxx>
>             To change your delivery options, retrieve your password, or
>             unsubscribe from this list, visit
>             https://www.eclipse.org/mailman/listinfo/platform-swt-dev
>
>         --
>
>         Leo Ufimtsev
>
>         Senior Consultant, Red Hat Certified Engineer #150-127-462
>         Red Hat Consulting
>         Leonidas@xxxxxxxxxx <mailto:Leonidas@xxxxxxxxxx>
>
>         _______________________________________________
>         platform-swt-dev mailing list
>         platform-swt-dev@xxxxxxxxxxx <mailto:platform-swt-dev@xxxxxxxxxxx>
>         To change your delivery options, retrieve your password, or
>         unsubscribe from this list, visit
>         https://www.eclipse.org/mailman/listinfo/platform-swt-dev
>
>
>
>     --
>
>     Alexander Kurtakov
>
>     Red Hat Eclipse Team
>
>     _______________________________________________
>     platform-swt-dev mailing list
>     platform-swt-dev@xxxxxxxxxxx <mailto:platform-swt-dev@xxxxxxxxxxx>
>     To change your delivery options, retrieve your password, or
>     unsubscribe from this list, visit
>     https://www.eclipse.org/mailman/listinfo/platform-swt-dev
>
>
>
> --
>
> Alexander Kurtakov
>
> Red Hat Eclipse Team
>
>
>
> _______________________________________________
> platform-swt-dev mailing list
> platform-swt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/platform-swt-dev
>
_______________________________________________
platform-swt-dev mailing list
platform-swt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-swt-dev

Back to the top