Re: [platform-dev] Cannot push to github git@xxxxxxxxxx:eclipse-platform

[Jonah Graham <jonah@xxxxxxxxxxxxxxxx>]

Hi Marcus,

One step you need to do is connect your Eclipse and GitHub accounts - see this email I wrote a while ago for advice: https://www.eclipse.org/lists/eclipse-dev/msg11927.html

Jonah

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com

On Wed, 18 May 2022 at 10:49, Lars Vogel <lars.vogel@xxxxxxxxxxx> wrote:

Marcus, as you are a committer for platform you should be able to assign reviewers to your PRs

On Wed, May 18, 2022 at 2:54 PM Hoepfner, Marcus via platform-dev <platform-dev@xxxxxxxxxxx> wrote:

I don’t even see proposals for reviewers.

 

From: platform-dev <platform-dev-bounces@xxxxxxxxxxx> on behalf of Ed Merks <ed.merks@xxxxxxxxx>
Date: Wednesday, 18. May 2022 at 14:45
To: platform-dev@xxxxxxxxxxx <platform-dev@xxxxxxxxxxx>
Subject: Re: [platform-dev] Cannot push to github git@xxxxxxxxxx:eclipse-platform/eclipse.platform.ui.git

Marcus,

I got a notification like this:

This issue of not being able to assign a reviewer came up recently too.  I'm not sure how that's being resolved.  But I do think committers will generally be notified so hopefully one of them adds themself.

Do you see this part?

I suppose you could add a comment with @vogella to send a more directed notification...

 

 

On 18.05.2022 14:40, Hoepfner, Marcus via platform-dev wrote:

Thanks.

 

I have created a fork and a PR now on https://github.com/eclipse-platform/eclipse.platform.ui.

Unfortunately I cannot add Reviewers to the PR.

 

Guess that’s because I’m not contributor in platform.ui?

 

From: platform-dev <platform-dev-bounces@xxxxxxxxxxx> on behalf of Ed Merks <ed.merks@xxxxxxxxx>
Date: Wednesday, 18. May 2022 at 13:44
To: platform-dev@xxxxxxxxxxx <platform-dev@xxxxxxxxxxx>
Subject: Re: [platform-dev] Cannot push to github git@xxxxxxxxxx:eclipse-platform/eclipse.platform.ui.git

The more detailed instructions are here:

  https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#recommended-workflow

Yes, you should use a fork with pull requests.

I generally clone the "real" repository and create an additional remote that points at my fork:

I leave master hooked up to origin/master and create a local branch that I push to my fork remote.  When I'm done I check out master again and can always pull from the real original clone (so no need to manually sync my fork with the original).

 

On 18.05.2022 13:36, Hoepfner, Marcus via platform-dev wrote:

Hi,

 

did not follow all the discussion how to contribute after moved to github.

 

Do I need to fork or can I push to new branch in git@xxxxxxxxxx:eclipse-platform/eclipse.platform.ui.git?

How do I become contributer in that repo?

 

I want to develop a feature, not about a bug fix.

 

https://github.com/eclipse-platform/eclipse.platform.ui/blob/master/CONTRIBUTING.md does not really say a lot and points to a wiki page which is talking about gerrit.

 

Thanks, Marcus

_______________________________________________

platform-dev mailing list

platform-dev@xxxxxxxxxxx

To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev

_______________________________________________

platform-dev mailing list

platform-dev@xxxxxxxxxxx

To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev

_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev

--

Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com

_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev