| [platform-dev] Github PR's & jenkins settings |
Hi, In [1] I've stumbled on a weird Jenkins / github feature that tried to automatically merge & rebuild your PR if master branch had new commits. Not only that caused extra load on limited jenkins resources, it also didn't actually test *your* PR 1:1 as you would expect, but some merged state on top of origin branch HEAD commit. It might be useful in some cases, but I personally expect that system tests what I've submitted, not what the system merges for me and assumes that that's fine. This was also recommended action in [2]: "We also recommend to change the 'Discover pull requests from origin' and 'Discover pull requests from forks' strategies from 'Merging the pull request with the current target branch revision' to 'The current pull request revision'. This would prevent a rebuild on reindexing if the target branch has changed since last commit" ... but was only done for one single job. So I took the freedom to change this settings for all github jobs I've found in platform/jdt/pde/equinox CI instances (https://ci.eclipse.org/platform/, https://ci.eclipse.org/jdt/, https://ci.eclipse.org/pde/, https://ci.eclipse.org/equinox/). [1] https://github.com/eclipse-jdt/eclipse.jdt.core/pull/38#issuecomment-1109908918 [2] https://www.eclipse.org/lists/platform-dev/msg03542.html Kind regards, Andrey Loskutov Спасение утопающих - дело рук самих утопающих https://www.eclipse.org/user/aloskutov