[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [platform-dev] Has the time come?
|
I preface everything I say on this thread with the observation that "I
am completely uniformed on the details"... All this squash-merge,
force-push means very little to me so I'm admittedly highly ignorant...
I continue to get the sense that decisions are being made on what feels
like a knee-jerk basis. I don't intend to offend anyone with that
comment, so please don't take offense. It just seems we keep seeing
anecdotes and factoids floating by.
Rolf's suggestion of gathering facts and making decisions based on a
full set of confirmed facts would be ideal for such an important
decision. Perhaps a table with the important considerations as the rows
and github versus gitlab as the columns to get a feeling of the pos and
cons. Having used gitlab for several customer projects it's doesn't
feel all that different from github to me. It has a bit of a "the
latest cool new thing' feeling to it, so it makes me wonder why all the
cool kids aren't flocking too it...
In terms of this specific latest detail, wouldn't Eclipse have 100%
control over any limits on gitlab.eclipse.org?
On 16.03.2021 12:35, Lars Vogel wrote:
That would be a bad restriction for the for project. Some projects use
actions already like Windowbuilder and Wild Web Developer, AFAIK they
have not seen issues with time limitations yet. Link for
windowbuilder: https://github.com/eclipse/windowbuilder
On the plus side, every fork would get the same amount of free
minutes, so contributors which fork the repo to send PR would be able
to use this action validation on their side.
On Tue, Mar 16, 2021 at 12:31 PM Sebastian Zarnekow
<sebastian.zarnekow@xxxxxxxxx> wrote:
I may be wrong but I think the Eclipse foundation would fall under the category GitHub Free for Organizations so as a total it would get 2000 mins for *all* its repositories according to https://docs.github.com/en/github/setting-up-and-managing-billing-and-payments-on-github/about-billing-for-github-actions - as I said, I may be wrong about this, but that's what I understood.
On Tue, Mar 16, 2021 at 12:10 PM Lars Vogel <lars.vogel@xxxxxxxxxxx> wrote:
https://github.com/pricing
2,000 Actions minutes/month Free for public repositories so we would
get ~ 33 hours of free and fast build time per month and repo. Not
sufficient for our daily aggregator build but really nice for
validation builds and sufficient for most platform repo activities
AFAICS.
On Tue, Mar 16, 2021 at 12:00 PM Sebastian Zarnekow
<sebastian.zarnekow@xxxxxxxxx> wrote:
As far as I know, there are usage limits for organizations when it comes to Github runners / actions - even for open source projects. Can you please share the source of your information, Lars?
On Tue, Mar 16, 2021 at 11:42 AM Lars Vogel <lars.vogel@xxxxxxxxxxx> wrote:
Moving to Github would allow us to use Github actions for build
verification (using Maven), which can be easily configured to be cross
platform and cross Java versions and are free for Open Source projects
and run on the Github infrastructure which seems better in terms of
scalability and availability compared to the Eclipse foundation
infrastructure.
So if we have to move to a new hosting platform, +1 for Github from me.
On Tue, Mar 16, 2021 at 11:06 AM Mickael Istria <mistria@xxxxxxxxxx> wrote:
On Tue, Mar 16, 2021 at 10:54 AM Sebastian Zarnekow <sebastian.zarnekow@xxxxxxxxx> wrote:
Looking at the https://github.com/eclipse/lemminx-maven/pull/205 I don't see the comments *on* the previous commit that became obsolete due to a force push. I can still see them as outdated in the linear conversation though. This is also the case on Gitlab though. So the force-push habit (which is inherently necessary if FF-only merges are allowed) has an impact on the way we can associate comments with versions of a patch-set.
Indeed, it's slightly more complicated. But the data is here: the comments keep reference to the commit, so even after a force-push, it's still possible to find out which version of the commit the comment applies to, and to get access to the content of that former commit.
But the `... forced-push ...` line could probably be improved with a link to show a diff of the commits, and ideally this diff link would show data in the context of the PR, eg be capable of showing comments.
I'm going to open a feature request to GitHub about it and will keep you in touch if this improves at some point.
However, I agree that if we want to make things simpler via GitHub, we probably need to enable workflows that do not involve force-push, and instead rely on GitHub capability to "squash and merge" and let committers use it if they feel it's better than asking submitter for a force-push.
--
Mickael Istria
Eclipse IDE developer, for Red Hat Developers
_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
--
Eclipse Platform project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
--
Eclipse Platform project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
